Create a target_rails_release column at lockfile_checks

[JuanVqz]

Context

In case something happens while running the DirectResolver and it fails, we can have a lockfile_check record with all the information we need to reproduce the error locally and fix it without a doubt.

Done When

• Create a migration to add the target_rails_release
• Should be used here:

  app/app/services/checks/create.rb

  Lines 21 to 26 in a93ad09

  	lockfile_check = @lockfile.lockfile_checks.find_or_create_by!(rails_release: target_release) do |check|
  	check.status = "pending"
  	check.ruby_version = runtime[:ruby_version]
  	check.rubygems_version = runtime[:rubygems_version]
  	check.bundler_version = runtime[:bundler_version]
  	end

[JuanVqz]

@jeremysmithco I remember you mentioning something about having all the variants saved, so we can replicate them in case something fails and we can debug, was it the current rails version or something else we can save?

[jeremysmithco]

Yeah, it was the target Rails version (exact patch release, since just storing the minor release wouldn't tell us the specific version being resolved).

I've been thinking more about why I had said I was hesitant to store this value, and I think I can explain it now.

When we specify a target Rails release, we're only specifying to the level of a minor version of Rails, not down to the exact patch release. Once we know that target minor Rails release, that leaves us a couple options:

1. We could call RubyGems to get the current patch release for that target minor Rails release, and specify that exact version in our dependency requirements passed to the resolver (e.g. rails (= 8.1.3)). Or...
2. We could use the pessimistic version constraint to use the latest patch of the target minor Rails release (e.g. rails (~> 8.1.0)). This is what we are doing right now.

The benefit of 1 is that we specify at the LockfileCheck level exactly what patch release of Rails we're checking. The benefit of 2 is that we don't have to do a separate check for the latest patch release of a minor version of Rails, or risk using stale data if we cache it.