From 83f0c40f71d8b215320add1892841204e6fa48a4 Mon Sep 17 00:00:00 2001 From: Jonathan Simpson Date: Sat, 17 Jan 2026 10:09:05 -0500 Subject: [PATCH] don't set list-box% content when set-string given column > 0 - calling set-string with a column argument other than 0 overwrites content, which doesn't appear to store any data other than the string to display in column 0. this breaks future calls to get-string. --- gui-lib/mred/private/mritem.rkt | 3 ++- gui-test/tests/gracket/windowing.rktl | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/gui-lib/mred/private/mritem.rkt b/gui-lib/mred/private/mritem.rkt index bfcb1b851..5eae3f7c3 100644 --- a/gui-lib/mred/private/mritem.rkt +++ b/gui-lib/mred/private/mritem.rkt @@ -903,7 +903,8 @@ (sub1 num-columns) #f))) (check-item 'set-string n) - (send this -set-list-string n d) + (when (= col 0) + (send this -set-list-string n d)) (send wx set-string n d col)))] [set-data (entry-point (lambda (n d) (check-item 'set-data n) (send wx set-data n d)))] [get-first-visible-item (entry-point (lambda () (send wx get-first-item)))] diff --git a/gui-test/tests/gracket/windowing.rktl b/gui-test/tests/gracket/windowing.rktl index 7f2cc5966..a6347cba4 100644 --- a/gui-test/tests/gracket/windowing.rktl +++ b/gui-test/tests/gracket/windowing.rktl @@ -875,7 +875,9 @@ (st '(0 1) l get-column-order) (stv l set-column-order '(1 0)) (st '(1 0) l get-column-order) + (define old (send l get-string 0)) (stv l set-string 0 "A2" 1) + (st old l get-string 0) (check-col-width 1) (stv l append-column "Three") (check-col-width 2)