From 34af4c851c2af658f5959a169c0b98949d624960 Mon Sep 17 00:00:00 2001 From: govindchari Date: Mon, 20 Apr 2026 16:43:27 -0700 Subject: [PATCH 1/5] Make changes for robustification PR --- CMakeLists.txt | 4 ++-- src/bindings.cpp.in | 3 ++- tests/test_lcvx_bad_scale.py | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 1f6b602..349d9df 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,7 +23,7 @@ include(FetchContent) FetchContent_Declare( qoco GIT_REPOSITORY https://github.com/qoco-org/qoco.git - GIT_TAG 0771532c6195e7669eada2e062d98d3065da9bd0 + GIT_TAG 30f10e982b1faf676170bca3bfc6e89b57761e0a ) list(POP_BACK CMAKE_MESSAGE_INDENT) @@ -41,4 +41,4 @@ elseif(${QOCO_ALGEBRA_BACKEND} STREQUAL "cuda") enable_language(CUDA) find_package(CUDA) target_link_libraries(qoco_cuda PUBLIC pybind11::module qocostatic) -endif() \ No newline at end of file +endif() diff --git a/src/bindings.cpp.in b/src/bindings.cpp.in index 15526d3..fdadf7e 100644 --- a/src/bindings.cpp.in +++ b/src/bindings.cpp.in @@ -340,7 +340,8 @@ PYBIND11_MODULE(@QOCO_EXT_MODULE_NAME@, m) { return new QOCOSettings(); })) .def_readwrite("max_iters", &QOCOSettings::max_iters) .def_readwrite("ruiz_iters", &QOCOSettings::ruiz_iters) - .def_readwrite("iter_ref_iters", &QOCOSettings::iter_ref_iters) + .def_readwrite("max_ir_iters", &QOCOSettings::max_ir_iters) + .def_readwrite("ir_tol", &QOCOSettings::ir_tol) .def_readwrite("abstol", &QOCOSettings::abstol) .def_readwrite("reltol", &QOCOSettings::reltol) .def_readwrite("abstol_inacc", &QOCOSettings::abstol_inacc) diff --git a/tests/test_lcvx_bad_scale.py b/tests/test_lcvx_bad_scale.py index bc093b3..21edc93 100644 --- a/tests/test_lcvx_bad_scale.py +++ b/tests/test_lcvx_bad_scale.py @@ -92,7 +92,7 @@ def test_lcvx_bad_scaling(): prob_qoco = qoco.QOCO() prob_qoco.setup( - n, m, p, P, c, A, b, G, h, l, nsoc, q, ruiz_iters=5, iter_ref_iters=3 + n, m, p, P, c, A, b, G, h, l, nsoc, q, ruiz_iters=5, max_ir_iters=3 ) # Solve problem. From 1b3fd3ab6f23f1ea9f11ee300ff9557740ab0ccf Mon Sep 17 00:00:00 2001 From: govindchari Date: Wed, 22 Apr 2026 13:03:42 -0700 Subject: [PATCH 2/5] Bump commit --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 349d9df..694f75c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,7 +23,7 @@ include(FetchContent) FetchContent_Declare( qoco GIT_REPOSITORY https://github.com/qoco-org/qoco.git - GIT_TAG 30f10e982b1faf676170bca3bfc6e89b57761e0a + GIT_TAG 108d102727a2e664c5d4f9ee94de9e56bc8ac5d6 ) list(POP_BACK CMAKE_MESSAGE_INDENT) From 556bd10e3265bf7914dfca7f796836d5aa586582 Mon Sep 17 00:00:00 2001 From: govindchari Date: Wed, 22 Apr 2026 13:11:23 -0700 Subject: [PATCH 3/5] Fixed settings bindings --- src/bindings.cpp.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bindings.cpp.in b/src/bindings.cpp.in index fdadf7e..cd1fc33 100644 --- a/src/bindings.cpp.in +++ b/src/bindings.cpp.in @@ -346,7 +346,9 @@ PYBIND11_MODULE(@QOCO_EXT_MODULE_NAME@, m) .def_readwrite("reltol", &QOCOSettings::reltol) .def_readwrite("abstol_inacc", &QOCOSettings::abstol_inacc) .def_readwrite("reltol_inacc", &QOCOSettings::reltol_inacc) - .def_readwrite("kkt_static_reg", &QOCOSettings::kkt_static_reg) + .def_readwrite("kkt_static_reg_P", &QOCOSettings::kkt_static_reg_P) + .def_readwrite("kkt_static_reg_A", &QOCOSettings::kkt_static_reg_A) + .def_readwrite("kkt_static_reg_G", &QOCOSettings::kkt_static_reg_G) .def_readwrite("kkt_dynamic_reg", &QOCOSettings::kkt_dynamic_reg) .def_readwrite("verbose", &QOCOSettings::verbose); From 96f904c5e3a3fa9b8d01f7b79ea0c414795ed77f Mon Sep 17 00:00:00 2001 From: govindchari Date: Tue, 28 Apr 2026 18:03:47 -0700 Subject: [PATCH 4/5] Bump hash --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 694f75c..29cc8b9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,7 +23,7 @@ include(FetchContent) FetchContent_Declare( qoco GIT_REPOSITORY https://github.com/qoco-org/qoco.git - GIT_TAG 108d102727a2e664c5d4f9ee94de9e56bc8ac5d6 + GIT_TAG b8c1936cf47518378d719db3085c4ecae664eac8 ) list(POP_BACK CMAKE_MESSAGE_INDENT) From 21bd0e07eb5559910bf32870bac6c31fb44c2055 Mon Sep 17 00:00:00 2001 From: govindchari Date: Thu, 30 Apr 2026 18:22:38 -0700 Subject: [PATCH 5/5] bump hash --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 29cc8b9..0234c9f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,7 +23,7 @@ include(FetchContent) FetchContent_Declare( qoco GIT_REPOSITORY https://github.com/qoco-org/qoco.git - GIT_TAG b8c1936cf47518378d719db3085c4ecae664eac8 + GIT_TAG 6dd96bf4cd231518c781e7c2bf296fa55b464610 ) list(POP_BACK CMAKE_MESSAGE_INDENT)