From 0ee846ec25a905cfc217231101e7b5ffca59d35f Mon Sep 17 00:00:00 2001 From: Minh Vu Date: Sun, 21 Jun 2026 20:16:13 +0200 Subject: [PATCH] Fix Scribe uploader torchvision schema --- scripts/upload_scribe.py | 1 + scripts/upload_scribe_v2.py | 1 + test_upload_scribe.py | 11 +++++++++++ 3 files changed, 13 insertions(+) create mode 100644 test_upload_scribe.py diff --git a/scripts/upload_scribe.py b/scripts/upload_scribe.py index 392adca69..51f11b2dd 100644 --- a/scripts/upload_scribe.py +++ b/scripts/upload_scribe.py @@ -89,6 +89,7 @@ def __init__(self): "git_commit_time", "git_dirty", "pytorch_version", + "torchvision_version", "python_version", "machine_kernel", "machine_processor", diff --git a/scripts/upload_scribe_v2.py b/scripts/upload_scribe_v2.py index 441ebd548..2a0ea0893 100644 --- a/scripts/upload_scribe_v2.py +++ b/scripts/upload_scribe_v2.py @@ -122,6 +122,7 @@ def __init__(self): "git_commit_time", "git_dirty", "pytorch_version", + "torchvision_version", "python_version", "machine_kernel", "machine_processor", diff --git a/test_upload_scribe.py b/test_upload_scribe.py new file mode 100644 index 000000000..1147b1328 --- /dev/null +++ b/test_upload_scribe.py @@ -0,0 +1,11 @@ +import importlib + + +def test_scribe_uploaders_accept_torchvision_version(): + for module_name in ("scripts.upload_scribe", "scripts.upload_scribe_v2"): + module = importlib.import_module(module_name) + message = module.PytorchBenchmarkUploader().format_message( + {"time": 1, "torchvision_version": "0.18.0"} + ) + + assert message["normal"]["torchvision_version"] == "0.18.0"