From 917a813926c4700f8f4656abaffb27e1b3317e2c Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Thu, 9 Apr 2026 23:38:51 -0700 Subject: [PATCH 1/5] Require `lib` in tests instead of `dist` --- spec/composite-disposable-spec.js | 3 +-- spec/disposable-spec.js | 2 +- spec/emitter-spec.js | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/spec/composite-disposable-spec.js b/spec/composite-disposable-spec.js index 55e5a55..bfabb34 100644 --- a/spec/composite-disposable-spec.js +++ b/spec/composite-disposable-spec.js @@ -1,5 +1,4 @@ -const CompositeDisposable = require("../dist/composite-disposable") -const Disposable = require("../dist/disposable") +const { CompositeDisposable, Disposable } = require("../lib/event-kit.js"); describe("CompositeDisposable", function() { let disposable1, disposable2, disposable3 diff --git a/spec/disposable-spec.js b/spec/disposable-spec.js index 0f9716d..908dfdc 100644 --- a/spec/disposable-spec.js +++ b/spec/disposable-spec.js @@ -1,4 +1,4 @@ -const Disposable = require("../dist/disposable") +const { Disposable } = require("../lib/event-kit.js"); describe("Disposable", function() { it("does not try to execute disposalAction when it is not a function", function() { diff --git a/spec/emitter-spec.js b/spec/emitter-spec.js index 6f63b97..519425f 100644 --- a/spec/emitter-spec.js +++ b/spec/emitter-spec.js @@ -1,4 +1,4 @@ -const Emitter = require("../dist/emitter") +const { Emitter } = require("../lib/event-kit.js"); describe("Emitter", function() { it("invokes the observer when the named event is emitted until disposed", function() { From 2815f862989473b31b4e477c5a13608abb956c17 Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Thu, 9 Apr 2026 23:39:12 -0700 Subject: [PATCH 2/5] Update `main` key --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5efa0a5..79c34d1 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "event-kit", "version": "2.5.3", "description": "Simple library for implementing and consuming evented APIs", - "main": "./dist/event-kit", + "main": "./lib/event-kit.js", "scripts": { "build": "cross-env BABEL_KEEP_MODULES=false babel lib --out-dir dist --delete-dir-on-start", "docs": "joanna-tello -o api.json package.json lib", From fb75aa6cf64f3e3f95c23aa212794b760e9ea893 Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Thu, 9 Apr 2026 23:39:56 -0700 Subject: [PATCH 3/5] Remove `build` script & build dependencies --- package.json | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/package.json b/package.json index 79c34d1..fa39043 100644 --- a/package.json +++ b/package.json @@ -4,9 +4,8 @@ "description": "Simple library for implementing and consuming evented APIs", "main": "./lib/event-kit.js", "scripts": { - "build": "cross-env BABEL_KEEP_MODULES=false babel lib --out-dir dist --delete-dir-on-start", "docs": "joanna-tello -o api.json package.json lib", - "prepublish": "npm run build && npm run docs", + "prepublish": "npm run docs", "test": "jasmine-focused --captureExceptions --forceexit spec" }, "repository": { @@ -18,10 +17,6 @@ }, "license": "MIT", "devDependencies": { - "@babel/cli": "^7.12.10", - "@babel/core": "^7.12.10", - "babel-preset-atomic": "^3.0.1", - "cross-env": "^7.0.3", "jasmine-focused": "^1.0.7", "joanna": "https://github.com/aminya/joanna" } From bafe3ad270e7ab14504ac1c4096a4869534cb7b6 Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Thu, 9 Apr 2026 23:43:20 -0700 Subject: [PATCH 4/5] Update test that relies on ES5-style classes --- spec/disposable-spec.js | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/spec/disposable-spec.js b/spec/disposable-spec.js index 908dfdc..0d58246 100644 --- a/spec/disposable-spec.js +++ b/spec/disposable-spec.js @@ -23,19 +23,18 @@ describe("Disposable", function() { expect(disposalAction.callCount).toBe(1) }) - it('can be extended by ES5-style classes', () => { - function MyDisposable () { - // super - Disposable.apply(this, arguments) + it("can be extended by ES6-style classes", () => { + class MyDisposable extends Disposable { + constructor(...args) { + super(...args); + } } - MyDisposable.prototype = new Disposable() - - let actionCalled = false - const disposable = new MyDisposable(() => { actionCalled = true }) - disposable.dispose() - expect(actionCalled).toBe(true) - }) + let actionCalled = false; + const disposable = new MyDisposable(() => { actionCalled = true }); + disposable.dispose(); + expect(actionCalled).toBe(true); + }); describe(".isDisposable(object)", () => { it("true if the object implements the ::dispose function", function() { From 39659396ad8bef3eec858fb6819cfc69c0497b80 Mon Sep 17 00:00:00 2001 From: confused-Techie Date: Thu, 9 Apr 2026 23:44:39 -0700 Subject: [PATCH 5/5] Remove `babel.config.js` --- babel.config.js | 10 ---------- 1 file changed, 10 deletions(-) delete mode 100644 babel.config.js diff --git a/babel.config.js b/babel.config.js deleted file mode 100644 index 873b92c..0000000 --- a/babel.config.js +++ /dev/null @@ -1,10 +0,0 @@ -let presets = ["babel-preset-atomic"]; - -let plugins = ["@babel/plugin-transform-classes"] // this is needed so Disposabale can be extended by ES5-style classes - -module.exports = { - presets: presets, - plugins: plugins, - exclude: "node_modules/**", - sourceMap: true, -}