From 6801150425deb4bedb9b015f5a1b49fc4372d48b Mon Sep 17 00:00:00 2001
From: Jonathan Keane <jkeane@gmail.com>
Date: Wed, 24 Jun 2026 08:37:10 -0500
Subject: [PATCH] remove our workaround for mistune

---
 pyproject.toml           |  1 -
 tests/test_quickstart.py | 11 ++---------
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/pyproject.toml b/pyproject.toml
index aa4ef4a2..f35ba49a 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -30,7 +30,6 @@ test = [
     "flake8",
     "httpretty",
     "ipykernel",
-    "mistune<3.3; python_version=='3.8'",  # 3.3+ uses re.Pattern[str], invalid on 3.8
     "nbconvert",
     "pyright",
     "pytest-cov",
diff --git a/tests/test_quickstart.py b/tests/test_quickstart.py
index 4aa4b963..ad1a442b 100644
--- a/tests/test_quickstart.py
+++ b/tests/test_quickstart.py
@@ -819,20 +819,13 @@ def fake_get_data(package: str, resource: str):
 # ---------------------------------------------------------------------------
 
 
-# nbconvert pulls mistune>=3.3, which uses re.Pattern[str] and is broken on
-# Python 3.8; skip the jupyter-based scaffolds there.
-_PY38_NBCONVERT_SKIP = pytest.mark.skipif(
-    sys.version_info < (3, 9),
-    reason="nbconvert pulls mistune>=3.3 which is broken on Python 3.8",
-)
-
 BOOT_SMOKE_MATRIX = [
     pytest.param("streamlit", "http", id="streamlit"),
     pytest.param("shiny", "http", id="shiny"),
     pytest.param("fastapi", "http", id="fastapi"),
     pytest.param("api", "http", id="api"),
-    pytest.param("voila", "http", id="voila", marks=_PY38_NBCONVERT_SKIP),
-    pytest.param("notebook", "artifact", id="notebook", marks=_PY38_NBCONVERT_SKIP),
+    pytest.param("voila", "http", id="voila"),
+    pytest.param("notebook", "artifact", id="notebook"),
     pytest.param("quarto", "artifact", id="quarto"),
 ]