Skip to content
This repository was archived by the owner on Aug 6, 2020. It is now read-only.
This repository was archived by the owner on Aug 6, 2020. It is now read-only.

Thread-safety of vars in iteratee module #1

Description

@wsargent

From playframework/playframework#1076:

In the iteratees module we use vars in the iteratees package in what looks like a non-thread-safe way. We need to review each occurrence and possibly update it to be thread-safe, e.g. mark @volatile.

$ grep -n var *
Concurrent.scala:555:    var closeFlag = false
Concurrent.scala:697:      var isClosed: Boolean = false
Enumerator.scala:62:   * A variation on `apply` or `|>>` which returns the state of the iteratee rather
Enumerator.scala:361:      var iteratee: Iteratee[E, A] = it
Enumerator.scala:362:      var promise: scala.concurrent.Promise[Iteratee[E, A]] = Promise[Iteratee[E, A]]()
Enumerator.scala:546:      var iterateeP = Promise[Iteratee[E, A]]()
Enumerator.scala:586:      var iterateeP = Promise[Iteratee[E, A]]()
Enumerator.scala:761:  var iteratee: Iteratee[E, _] = _
Enumerator.scala:762:  var promise: Promise[Iteratee[E, _]] = _

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions