Docs: add more piped installation options#6595
Docs: add more piped installation options#6595rahulshendre wants to merge 4 commits intopipe-cd:masterfrom
Conversation
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
|
@eeshaanSA, I’ve tried to cover as much detail on each page as possible. PTAL and let me know what we should refine or expand further. |
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
|
@khanhtc1202, I’ve removed platformProviders from the Cloud Run, Fargate, and Google Cloud VM examples and aligned them with the v1 Kubernetes pattern. PTAL, and let me know if any other changes are needed |
| spec: | ||
| containerConcurrency: 1 # This must be 1 to ensure piped works correctly. | ||
| containers: | ||
| - image: gcr.io/pipecd/launcher:{{< blocks/latest_version >}} |
There was a problem hiding this comment.
If you actually run this, will realize the launcher currently doesn't work with pipedv1 (launcher only download pipedv0), so I think this config will not work
ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/app/launcher/cmd/launcher/launcher.go#L55
| spec: | ||
| containerConcurrency: 1 | ||
| containers: | ||
| - image: gcr.io/pipecd/launcher:{{< blocks/latest_version >}} |
There was a problem hiding this comment.
The pipedv1 config on tab without remote upgrade should use piped container image instead of launcher.
As we did on v0 docs: https://pipecd.dev/docs-v0.55.x/installation/install-piped/installing-on-cloudrun/
|
I still can easily point out issue from docs :( I recommend to ACTUALLY run the config used in docs, to ensure that is valid/workable docs. Please image yourself as the users that refer to this docs while using pipecd, what do you think they will feel when they follow docs but it's not working :( |
|
Thanks for pointing this out @khanhtc1202, you’re right, this config won’t work as it stands. I’ll revisit everything, verify it by actually running the setup, and will update the docs accordingly. |
2 participants
What this PR does:
Adds Cloud Run, ECS Fargate, and Google Cloud VM guides under the v1.0.x Install piped section
Took structure and content from the 0.55.x docs, updated for v1 terminology and current config reference
Why we need it:
The stateless piped binary can run on multiple environments beyond Kubernetes and local, which was previously only covered in older (0.55.x) docs.
This makes the v1.0.x docs reflect current, supported deployment options.
Which issue(s) this PR fixes:
Fixes #6541
Does this PR introduce a user-facing change?: