Skip to content

πŸ”’ Home module β€” replace real-looking external brand defaults (RFC-2606)Β #4340

Description

@PierreBrisorgueil

The home module's social-proof defaults hardcode a real-looking external brand + domain (and a second real-looking domain) as shipped defaults of this public stack β€” a generic-OSS hygiene violation (defaults must not reference a real third party).

Blast radius β€” 6 occurrence-pairs across 3 files (verified):

  • src/config/index.js (the bundled runtime default β€” the one that actually ships)
  • src/modules/home/config/home.development.config.js (module config source)
  • src/modules/home/components/home.social.component.vue (component default + comment example)

A component-only fix would close this while the bundled src/config/index.js keeps shipping the real domain β€” a half-fix. Fix all sites.

Proposed:

  1. Replace every occurrence with an RFC-2606 reserved placeholder (Example Co / https://example.com) β€” never trade one real domain for another.
  2. If src/config/index.js is generated from src/config/defaults/*, fix the source + regenerate (don't hand-edit the built file).
  3. Add a CI//verify grep-guard for hardcoded real brand/domain literals so it can't recur.
  4. The same contamination class also appears in lib/helpers/api.js:11 (comment) + an api.unit.tests.js fixture β€” fold into this checklist or file a sibling.

Split from a docs-cleanliness audit (a sibling issue), 2026-06-16. Public-OSS hygiene β€” ship promptly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions