From 2e9151694e65ef444c9842a64094dc46b993b4de Mon Sep 17 00:00:00 2001 From: Weilin Du Date: Wed, 12 Aug 2026 00:46:50 +0800 Subject: [PATCH 1/2] ext/readline: Fix class constant completion in readline interactive shell --- NEWS | 3 ++ ext/readline/readline_cli.c | 4 ++- ...eadline_cli_completion_class_constant.phpt | 29 +++++++++++++++++++ 3 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 ext/readline/tests/readline_cli_completion_class_constant.phpt diff --git a/NEWS b/NEWS index 6447fa7bc881..6abb9030412f 100644 --- a/NEWS +++ b/NEWS @@ -54,6 +54,9 @@ PHP NEWS . Fixed segfault in ReflectionMethod::createFromMethodName() on an uninstantiable subclass. (iliaal) +- Readline: + . Fixed class constant completion in the interactive shell. (Weilin Du) + - Session: . Fix corruption in mod_mm. (ndossche) . Fixed bug GH-23043 (broken session id code can cause zend_mm_heap diff --git a/ext/readline/readline_cli.c b/ext/readline/readline_cli.c index ca4e8eb4fe9f..ff5caee9eb7d 100644 --- a/ext/readline/readline_cli.c +++ b/ext/readline/readline_cli.c @@ -531,6 +531,7 @@ static char *cli_completion_generator(const char *text, int index) /* {{{ */ } else { char *lc_text; const char *class_name_end; + const char *constant_text = text; zend_string *class_name = NULL; zend_class_entry *ce = NULL; @@ -543,6 +544,7 @@ static char *cli_completion_generator(const char *text, int index) /* {{{ */ zend_string_release_ex(class_name, 0); return NULL; } + constant_text = class_name_end + 2; lc_text = zend_str_tolower_dup(class_name_end + 2, textlen - 2 - class_name_len); textlen -= (class_name_len + 2); } else { @@ -559,7 +561,7 @@ static char *cli_completion_generator(const char *text, int index) /* {{{ */ ZEND_FALLTHROUGH; case 2: case 3: - retval = cli_completion_generator_define(text, textlen, &cli_completion_state, ce ? &ce->constants_table : EG(zend_constants)); + retval = cli_completion_generator_define(constant_text, textlen, &cli_completion_state, ce ? &ce->constants_table : EG(zend_constants)); if (retval || ce) { break; } diff --git a/ext/readline/tests/readline_cli_completion_class_constant.phpt b/ext/readline/tests/readline_cli_completion_class_constant.phpt new file mode 100644 index 000000000000..21525c789d26 --- /dev/null +++ b/ext/readline/tests/readline_cli_completion_class_constant.phpt @@ -0,0 +1,29 @@ +--TEST-- +Interactive shell: class constant completion +--EXTENSIONS-- +readline +--SKIPIF-- + +--FILE-- + +--EXPECTF-- +%AInteractive shell%AZED_OK%A From 1825d3a4b107e185b5888c4845a2af9fb95aadcd Mon Sep 17 00:00:00 2001 From: Weilin Du Date: Wed, 12 Aug 2026 19:38:50 +0800 Subject: [PATCH 2/2] Apply suggestion from @iliaal Co-authored-by: Ilia Alshanetsky --- ext/readline/tests/readline_cli_completion_class_constant.phpt | 1 + 1 file changed, 1 insertion(+) diff --git a/ext/readline/tests/readline_cli_completion_class_constant.phpt b/ext/readline/tests/readline_cli_completion_class_constant.phpt index 21525c789d26..1d4e6228df01 100644 --- a/ext/readline/tests/readline_cli_completion_class_constant.phpt +++ b/ext/readline/tests/readline_cli_completion_class_constant.phpt @@ -13,6 +13,7 @@ $php = getenv('TEST_PHP_EXECUTABLE_ESCAPED'); $ini = getenv('TEST_PHP_EXTRA_ARGS'); putenv('TERM=VT100'); +putenv('INPUTRC=/dev/null'); $code = <<<'PHP' class Foo {