ext/curl: speed up tests - #23228
Open
Sjord wants to merge 3 commits into
Open
Conversation
By waiting shorter for the server to be ready. In my setup, this takes it from 26 to 15 seconds for all curl tests. The first check for output on stderr takes approximately 10ms, so we wait 20ms to make sure its ready. The second check for the open port typically succeeds immediately, so move the sleep to after we have tried.
Disable Expect: 100-continue to prevent libcurl's 1-second delay
Sjord
marked this pull request as ready for review
August 12, 2026 13:04
Contributor
Author
|
@NickSdot Could you take a look at this? |
NickSdot
reviewed
Aug 12, 2026
NickSdot
left a comment
NickSdot
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Can confirm it's ~40% faster -- nice! Added one nit.
| try { | ||
| // Give the server time to start | ||
| sleep(1); | ||
| for ($i = 0; $i < 100; $i++) { |
Contributor
There was a problem hiding this comment.
Suggested change
| for ($i = 0; $i < 100; $i++) { | |
| for ($i = 0; $i < 50; $i++) { |
Maybe 50 is enough? Would match the previous 1s; fsockopen already adds extra.
mvorisek
reviewed
Aug 12, 2026
|
|
||
| if (CURLOPT_INFILE == $curl_option) { | ||
| curl_setopt($ch, CURLOPT_UPLOAD, 1); | ||
| curl_setopt($ch, CURLOPT_HTTPHEADER, ['Expect:']); |
Contributor
There was a problem hiding this comment.
Disable Expect: 100-continue to prevent libcurl's 1-second delay.
May I ask where the 1 second delay come from?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By waiting shorter for the server to be ready. In my setup, this takes it from 26 to 15 seconds for all curl tests.
The first check for output on stderr takes approximately 10ms, so we wait 20ms to make sure its ready. The second check for the open port typically succeeds immediately, so move the sleep to after we have tried.
Disable Expect: 100-continue to prevent libcurl's 1-second delay.