TSRM: don't use initial-exec on AIX - #23145
Merged
Merged
Conversation
arnaud-lb
reviewed
Aug 10, 2026
arnaud-lb
left a comment
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
Should this target 8.4 ?
If building for ZTS, it seems that local-exec can sneak in:
```
PHP Warning: PHP Startup: Unable to load dynamic library 'intl' (tried: /QOpenSys/pkgs/lib/php-8.6/extensions/intl ( 0509-022 Cannot load module /QOpenSys/pkgs/lib/php-8.6/extensions/intl.
0509-026 System error: A file or directory in the path name does not exist.), /QOpenSys/pkgs/lib/php-8.6/extensions/intl.so ( 0509-130 Symbol resolution failed for /QOpenSys/pkgs/lib/php-8.6/extensions/intl.so because:
0509-189 Module /QOpenSys/pkgs/lib/php-8.6/extensions/intl.so is loaded dynamically,
but the initial-exec model is used by the module
to refer to its own thread-local variables.
0509-191 Examine .loader section relocation entries with the
'dump -Rv' command.
0509-192 Examine .loader section symbols with the
'dump -Tv' command.)) in Unknown on line 0
```
When inspecting the module for initial-exec:
```
$ dump -Rv /QOpenSys/pkgs/lib/php-8.6/extensions/intl.so | grep TLS_In
0x20014370 0x000001fb TLS_InExc 0x0003 _tsrm_ls_cache
```
It seems it only was in `ext/intl/timezone/timezone_class.cpp`. However,
it seems prudent to just not use local-exec for this case since it seems
to be an optimization only really possible on glibc; play it safe
elsewhere. (Perhaps this should be really an ifdef GLIBC check?)
Member
Author
|
Updated to target 8.4... somehow the rebase didn't break this time :) |
arnaud-lb
added a commit
that referenced
this pull request
Aug 11, 2026
* PHP-8.5: TSRM: don't use initial-exec on AIX (#23145)
Member
|
Thank you! |
pull Bot
pushed a commit
to ConnectionMaster/php-src
that referenced
this pull request
Aug 11, 2026
* PHP-8.4: TSRM: don't use initial-exec on AIX (php#23145)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If building for ZTS, it seems that local-exec can sneak in:
When inspecting the module for initial-exec:
It seems it only was in
ext/intl/timezone/timezone_class.cpp. However, it seems prudent to just not use local-exec for this case since it seems to be an optimization only really possible on glibc; play it safe elsewhere. (Perhaps this should be really an ifdef GLIBC check?)