Make strtolower()/strtoupper() frameless - #23084
Closed
staabm wants to merge 1 commit into
Closed
Conversation
Both are single-argument wrappers around zend_string_tolower/upper; static analyzers and general string handling call them at very high frequency. The frameless call convention removes the call frame setup and argument copying.
Contributor
Author
|
@iluuu1994 do you have a opinion on this frameless topic? |
Member
|
@staabm Sorry, didn't get to it yet. But looks reasonable. |
Member
|
Thanks @staabm and @ondrejmirtes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disclaimer: this change was generated by claude opus. I have little experience with php-src development
Both are single-argument wrappers around zend_string_tolower/upper; static analyzers and general string handling call them at very high frequency. The frameless call convention removes the call frame setup and argument copying.
benchmark (3 runs after 2 warmup runs):
run
/Users/staabm/workspace/php-src/sapi/cli/php bin/phpstan clear-result-cache -q && /Users/staabm/workspace/php-src/sapi/cli/php -d memory_limit=450M bin/phpstan -vafter checking out phpstan/phpstan-src#5942 from the git root folder.(on first time phpstan-src checkout you need
composer installandmaketo prepare the codebase)before this PR:
14.39s
14.44s
14.36s
after this PR:
14.18s
14.14s
14.12s
on M4-Pro with macOS 26.6 (25G72)