Possible way to deprecate dechunk filter - #22396
Closed
Sjord wants to merge 1 commit into
Closed
Conversation
Calls through the dechunk factory show the deprecation warning, but we expose chunked_filter_create and that is called directly in http_fopen_wrapper.c, so that it doesn't show the deprecation warning.
Contributor
Author
|
@bukka could you take a look at this? |
Contributor
Author
|
The dechunk filter is in the deprecations RFC, so this PR is waiting for the vote on that. |
Contributor
I don't think it is great to deprecate this without adding some functionality that allows exposing the functionality back to userland in a safer way. |
Contributor
Author
|
This didn't pass the vote in the RFC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls through the dechunk factory show the deprecation warning, but we expose chunked_filter_create and that is called directly in http_fopen_wrapper.c, so that it doesn't show the deprecation warning.
Related to #21983.