From e672af818353fc401ff27b427197448994a03449 Mon Sep 17 00:00:00 2001 From: WeidiDeng Date: Tue, 29 Jul 2025 11:15:39 +0800 Subject: [PATCH] check if caddy http app fails to provision due to not configured or invalid configuration --- caddy/app.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/caddy/app.go b/caddy/app.go index caedb566b6..9e02c0bff6 100644 --- a/caddy/app.go +++ b/caddy/app.go @@ -62,7 +62,12 @@ func (f *FrankenPHPApp) Provision(ctx caddy.Context) error { } } else { // if the http module is not configured (this should never happen) then collect the metrics by default - f.metrics = frankenphp.NewPrometheusMetrics(ctx.GetMetricsRegistry()) + if errors.Is(err, caddy.ErrNotConfigured) { + f.metrics = frankenphp.NewPrometheusMetrics(ctx.GetMetricsRegistry()) + } else { + // the http module failed to provision due to invalid configuration + return fmt.Errorf("failed to provision caddy http: %w", err) + } } return nil