From 294a6054c1a28e0d3ba91de6de58051b322161c3 Mon Sep 17 00:00:00 2001 From: Adam Patch Date: Thu, 18 Dec 2025 18:41:52 -0500 Subject: [PATCH 1/2] ci(e2e): remove deprecated Playwright action use and install Chromium browsers repo-locally; pin Ubuntu runner to 22.04; keep TMPDIR and --basetemp repo-local across tiers --- .github/workflows/tests.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 130b06d5..08350533 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -7,7 +7,7 @@ on: jobs: tests: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: python-version: ["3.12"] @@ -21,9 +21,13 @@ jobs: run: | python -m pip install --upgrade pip pip install -e .[dev] - - name: Install Playwright browsers + - name: Install Playwright browsers (repo-local, no root) if: matrix.tier == 'e2e' - uses: microsoft/playwright-github-action@v1 + env: + PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/dev/test-runs/pw-browsers + TMPDIR: ${{ github.workspace }}/dev/test-runs/tmp + run: | + python -m playwright install chromium - name: Prepare repo-local temp directories run: | mkdir -p dev/test-runs/{tmp,pytest-tmp,artifacts,downloads,pw-browsers} From 55e198293bd78b4743a49ff2bcc4e95b9ff9877a Mon Sep 17 00:00:00 2001 From: Adam Patch Date: Thu, 18 Dec 2025 18:49:16 -0500 Subject: [PATCH 2/2] ci(e2e): use npx playwright install-deps and install on ubuntu-latest; remove deprecated action; keep repo-local TMPDIR/--basetemp --- .github/workflows/tests.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 08350533..20e72c56 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -7,7 +7,7 @@ on: jobs: tests: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest strategy: matrix: python-version: ["3.12"] @@ -17,17 +17,18 @@ jobs: - uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} - - name: Install Python deps + - name: Upgrade pip and install Python deps run: | python -m pip install --upgrade pip pip install -e .[dev] - - name: Install Playwright browsers (repo-local, no root) + - name: Install Playwright system dependencies + if: matrix.tier == 'e2e' + run: | + npx playwright install-deps + - name: Install Playwright browsers if: matrix.tier == 'e2e' - env: - PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/dev/test-runs/pw-browsers - TMPDIR: ${{ github.workspace }}/dev/test-runs/tmp run: | - python -m playwright install chromium + npx playwright install - name: Prepare repo-local temp directories run: | mkdir -p dev/test-runs/{tmp,pytest-tmp,artifacts,downloads,pw-browsers}