From 704f1fa4a1c3794f2f7e1eea2b72eaf083495408 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=BCller?= <1005065+DeepDiver1975@users.noreply.github.com> Date: Thu, 18 Jun 2026 17:28:14 +0200 Subject: [PATCH 1/2] feat(config): expose allow_subadmins via OWNCLOUD_ALLOW_SUBADMINS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ownCloud core (oC 11) disables the subadmin/group-admin feature by default via the new allow_subadmins config setting. Expose it through the OWNCLOUD_ALLOW_SUBADMINS environment variable so operators can opt the feature back in without bind-mounting a custom config. This is an ownCloud 11 only setting, so the change applies to v24.04 only; v20.04 and v22.04 are intentionally left unchanged. Co-Authored-By: Claude Opus 4.8 Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> --- ENVIRONMENT.md | 2 ++ v24.04/overlay/etc/templates/config.php | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/ENVIRONMENT.md b/ENVIRONMENT.md index 68dbf46..45e6b0d 100644 --- a/ENVIRONMENT.md +++ b/ENVIRONMENT.md @@ -18,6 +18,8 @@ ownCloud admin password. - `OWNCLOUD_ADMIN_USERNAME=admin` \ ownCloud admin username. +- `OWNCLOUD_ALLOW_SUBADMINS=` \ + Enable or disable the subadmin (group admin) feature. Disabled by default in ownCloud core (see [documentation](https://doc.owncloud.com/server/latest/admin_manual/configuration/server/config_sample_php_parameters.html)). - `OWNCLOUD_ALLOW_USER_TO_CHANGE_DISPLAY_NAME=` \ Allow or disallow users to change their display names (see [documentation](https://doc.owncloud.com/server/latest/admin_manual/configuration/server/config_sample_php_parameters.html#allow-or-disallow-users-to-change-their-display-names)). - `OWNCLOUD_ALLOW_USER_TO_CHANGE_MAIL_ADDRESS=` \ diff --git a/v24.04/overlay/etc/templates/config.php b/v24.04/overlay/etc/templates/config.php index fe38444..bc5fb86 100644 --- a/v24.04/overlay/etc/templates/config.php +++ b/v24.04/overlay/etc/templates/config.php @@ -82,6 +82,10 @@ function getConfigFromEnv() { $config['allow_user_to_change_mail_address'] = getenv('OWNCLOUD_ALLOW_USER_TO_CHANGE_MAIL_ADDRESS') === 'true'; } + if (getenv('OWNCLOUD_ALLOW_SUBADMINS') != '') { + $config['allow_subadmins'] = getenv('OWNCLOUD_ALLOW_SUBADMINS') === 'true'; + } + if (getenv('OWNCLOUD_STRICT_LOGIN_ENFORCED') != '') { $config['strict_login_enforced'] = getenv('OWNCLOUD_STRICT_LOGIN_ENFORCED') === 'true'; } From 091d32e692619711f89a242f0883299b9dd962ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=BCller?= <1005065+DeepDiver1975@users.noreply.github.com> Date: Thu, 18 Jun 2026 19:26:44 +0200 Subject: [PATCH 2/2] docs: clarify OWNCLOUD_ALLOW_SUBADMINS usage and deep-link docs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address review feedback on PR #494: state that only the literal value `true` enables the feature and that leaving it unset keeps it disabled (ownCloud core default), and deep-link to the specific config sample parameter section like the neighbouring entries. Co-Authored-By: Claude Opus 4.8 Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> --- ENVIRONMENT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ENVIRONMENT.md b/ENVIRONMENT.md index 45e6b0d..ae829ea 100644 --- a/ENVIRONMENT.md +++ b/ENVIRONMENT.md @@ -19,7 +19,7 @@ - `OWNCLOUD_ADMIN_USERNAME=admin` \ ownCloud admin username. - `OWNCLOUD_ALLOW_SUBADMINS=` \ - Enable or disable the subadmin (group admin) feature. Disabled by default in ownCloud core (see [documentation](https://doc.owncloud.com/server/latest/admin_manual/configuration/server/config_sample_php_parameters.html)). + Enable or disable the subadmin (group admin) feature. Set to `true` to enable; unset leaves it disabled (ownCloud core default) (see [documentation](https://doc.owncloud.com/server/latest/admin_manual/configuration/server/config_sample_php_parameters.html#allow-or-disallow-the-group-administrator-subadmin-feature)). - `OWNCLOUD_ALLOW_USER_TO_CHANGE_DISPLAY_NAME=` \ Allow or disallow users to change their display names (see [documentation](https://doc.owncloud.com/server/latest/admin_manual/configuration/server/config_sample_php_parameters.html#allow-or-disallow-users-to-change-their-display-names)). - `OWNCLOUD_ALLOW_USER_TO_CHANGE_MAIL_ADDRESS=` \