Skip to content

Check recovery is paused after requesting pause#166

Open
OrioQuezac wants to merge 1 commit into
orgrim:masterfrom
OrioQuezac:check-recovery-pause-state
Open

Check recovery is paused after requesting pause#166
OrioQuezac wants to merge 1 commit into
orgrim:masterfrom
OrioQuezac:check-recovery-pause-state

Conversation

@OrioQuezac

Copy link
Copy Markdown

Closes #157

@l00ptr l00ptr self-requested a review June 5, 2026 13:52

@l00ptr l00ptr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OrioQuezac thx for your contribution, do you think we can add some test into internal/postgresql/sql_test.go for that new function ?

Comment thread internal/postgresql/sql.go Outdated
Comment thread internal/postgresql/sql.go Outdated
Comment thread internal/postgresql/sql.go Outdated
@OrioQuezac OrioQuezac force-pushed the check-recovery-pause-state branch from dcbebe6 to e135902 Compare June 9, 2026 08:57
@OrioQuezac

Copy link
Copy Markdown
Author

@l00ptr
As mentioned in sql_test.go, testing replication-related functions can be complex. However, we can also verify that function returns false with a non-recovery case. But the function isReplicationPaused needs to be adapted. What do you think about that ?

@OrioQuezac OrioQuezac requested a review from l00ptr June 9, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pg_back should check the "pause" state after the request to pause recovery.

2 participants