Skip to content

MaskPLS: semantic_embedding_distil and logits_sem_embed_grid padding #58

Description

@swahtz

When semantic_embedding_distil is enabled, logits_sem_embed_grid is produced only in the GRID branch and stays as an unpadded JaggedTensor, but downstream SemLoss indexes bb_sem_embed_logits[b][~padding[b]] (expects a padded [B, N, D] tensor like bb_sem_logits). Consider (1) generating the sem-embed logits in both XYZ and GRID modes, and (2) padding/batching them alongside logits via pad_batch(..., additional_feats=...) so the output format matches bb_sem_logits.

Originally posted by @Copilot in #57 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions