Add startup input prompting for prose run#72
Open
rawwerks wants to merge 2 commits into
Open
Conversation
Read local Contract Markdown caller inputs before forwarding run commands so interactive terminals can supply missing values deterministically. Preserve explicit CLI arguments and non-local targets, fail fast in non-TTY mode, and document/test the startup prompting behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deterministic startup input prompting for
prose runWhy
prose run <local-file.prose.md>could previously reach a service with missing### Requiresvalues and leave the problem to the agent harness. The harness might print a natural-language ask, but the CLI did not have a deterministic way to collect the answer and forward a completed command.This made the startup path hard to trust:
What changed
*.prose.mdruns.### Requiressection and extracts backtick-wrapped caller input names.--name valueand--name=valuearguments satisfy matching caller inputs.--no-promptis used.Design boundaries
This is intentionally startup-only deterministic input binding.
In scope:
prose run <file.prose.md>### Requires--name valueand--name=value--harness, literal args after--, and non-local package handlesOut of scope:
bindings/caller.prose/runsvsrunsHow to test
Automated:
Current local results:
npm test: 175 passednpm run typecheck: passednpm run build: passedManual TTY proof:
Expected behavior:
topicbefore the VM banner.--topic monkeys.monkeysandcaller-input-smoke-pass.Non-interactive proof:
prose run tests/open-prose/smoke/02-caller-input.prose.md < /dev/nullExpected behavior:
Explicit-input proof:
Expected behavior:
Reviewer notes
The main review target is the new startup input resolver. It deliberately sits before harness invocation and after existing command validation, so invalid commands still fail before skill preflight or prompting.
The resolver returns updated argv tokens instead of manipulating the canonical prompt string.
canonicalPromptremains the validation and shell-quoting boundary.Follow-ups
runs/over legacy.prose/runs/for native repo runs.