gnmic retries stream subscriptions even when server responds with PERMISSION_DENIED or RESOURCE_EXHAUSTED

[m08071998]

Hi gnmi developers

gnmic infinitely attempts to retry sending subscription stream request to the server even when it responds with PERMISSION_DENIED or RESOURCE_EXHAUSTED. This makes gnmic keep holding a connection with server using resources.

Looks like, gnmic does not handle any error code in response, and indefinitely attempts a retry.

Should the client not handle such error codes gracefully and not do indefinite reattempts on failures from which we cannot recover even on retries?

Thanks.

[karimra]

This can definitely be improved. At the time this was written most routers did not return proper gRPC errors so gNMIc did not inspect them and even if it did there was no distinction between retryable and non-retryable error.

[fnchooft]

Could one implement all the error-codes as defined here: https://www.openconfig.net/docs/gnmi/gnmi-specification/index.html#347-error-handling?

That would be of great help - specifically if the server provides the proper error-codes.