Skip to content

console output incomplete on odev pull #170

Description

@djoewie

Criticality

Low

What happened?

I looks like odev is missing an update for 1 worktree in the last repository.
The update of the last repos worktree is done, but the information is removed right after it is shown on the console.

Relevant log output

odoo@joemo-laptop:~/odoo/repositories/odoo/tutorials$ odev pull
[i] Fetched changes in repository 'odoo/odoo'                                                                                                                                          
[i] Fetched changes in repository 'odoo/enterprise'                                                                                                                                    
[i] Fetched changes in repository 'odoo/design-themes'                                                                                                                                 

[i] No pending changes for worktree 'master' in 'odoo/odoo' for version 'master'                                                                                                       
[i] No pending changes for worktree 'master' in 'odoo/enterprise' for version 'master'                                                                                                 
[i] No pending changes for worktree 'master' in 'odoo/design-themes' for version 'master'                                                                                              
[i] No pending changes for worktree '19.0' in 'odoo/odoo' for version '19.0'                                                                                                           
[i] No pending changes for worktree '19.0' in 'odoo/enterprise' for version '19.0'                                                                                                     
[i] No pending changes for worktree '19.0' in 'odoo/design-themes' for version '19.0'                                                                                                  
[i] No pending changes for worktree '18.0' in 'odoo/odoo' for version '18.0'                                                                                                           
[i] No pending changes for worktree '18.0' in 'odoo/enterprise' for version '18.0'                                                                                                     
odoo@joemo-laptop:~/odoo/repositories/odoo/tutorials$

What is expected?

when the terminal is finished you can see all the information of the repositories that are handled

odoo@joemo-laptop:~/odoo/repositories/odoo/tutorials$ odev pull
[i] Fetched changes in repository 'odoo/odoo'                                                                                                                                          
[i] Fetched changes in repository 'odoo/enterprise'                                                                                                                                    
[i] Fetched changes in repository 'odoo/design-themes'                                                                                                                                 

[i] No pending changes for worktree 'master' in 'odoo/odoo' for version 'master'                                                                                                       
[i] No pending changes for worktree 'master' in 'odoo/enterprise' for version 'master'                                                                                                 
[i] No pending changes for worktree 'master' in 'odoo/design-themes' for version 'master'                                                                                              
[i] No pending changes for worktree '19.0' in 'odoo/odoo' for version '19.0'                                                                                                           
[i] No pending changes for worktree '19.0' in 'odoo/enterprise' for version '19.0'                                                                                                     
[i] No pending changes for worktree '19.0' in 'odoo/design-themes' for version '19.0'                                                                                                  
[i] No pending changes for worktree '18.0' in 'odoo/odoo' for version '18.0'                                                                                                           
[i] No pending changes for worktree '18.0' in 'odoo/enterprise' for version '18.0'                                                                                                     
**[i] No pending changes for worktree '18.0' in 'odoo/design-themes' for version '18.0'**                                                                                                  
odoo@joemo-laptop:~/odoo/repositories/odoo/tutorials$ 

Possible implementation

I see 3 options, both have little drawbacks

  1. remove self.console.clear_line() in FetchCommand.run() line 40
    downside: this will leave a blank line a the end when you did a fetch
    upside: quick
  2. add self.console.print() at the end in PullCommand.run_hook
    downside: there will be blank lines between the different worktrees
    upside: quick
  3. add self.console.print() at the end in PullCommand.run_hook and a title line at the start to indicate the worktree
    downside: load more overhead in the console
    upside: follows the look of the fetch command

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions