Skip to content

modules: delete the stop-loss example, subsumed by the generic ComposableCoW monitor #568

Description

@mfw78

Delete the stop-loss example module. Its role is subsumed by the generic ComposableCoW monitor, so a separate hand-rolled submitter example is redundant.

Why

modules/examples/stop-loss hand-rolls its own submitted:{id} dedup against host.get/host.set (src/strategy.rs:80-111) rather than going through the keeper Journal, and builds an unsigned pre-sign order on a path the generic monitor already covers. Keeping it means a second, divergent copy of submit-and-dedup logic that every keeper-side change has to carry.

Removing it also clears the worst collision seam in the M4 and M3 follow-up work: modules/examples/stop-loss/src/strategy.rs was taking four M4 touches (#538, #545, #546, #522) plus M3's #544 at :91. With the module gone those all dissolve.

Scope

Remove the crate and its workspace member, drop it from Cargo.lock, from any engine.*.toml that installs it, from the CI guest-wasm build list (the count drops from 18), from the justfile, and from docs that name it as an example. Verify check-venue-agnostic.sh and check-cow-orderbook-only.sh still pass and the wasm count assertion is updated.

Ordering

Land this before or at the start of the M4 follow-up waves, so #538, #545 and #546 never touch a file that is about to be deleted. It removes work from every one of those.

Acceptance criteria

No modules/examples/stop-loss in the tree, no dangling reference in manifests, CI, the justfile or docs, and the full battery green with the corrected wasm count.

Metadata

Metadata

Assignees

No one assigned

    Labels

    component/modulesshipped guest modules (twap, ethflow, examples, fixtures)debtCode works but makes future work harder.effort/hoursFew hours. Single PR.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions