Follow-up from review of #428 (comment).
The videre rename dropped the empty-receipt rejection. status/cancel previously rejected an empty receipt with VenueError::InvalidReceipt, and disowned_receipt_is_dropped_from_the_watch covered it. Both the InvalidReceipt variant and the test were removed in the rename rather than adapted, so both paths now succeed unconditionally on any receipt, including empty ones.
Confirmed still present at the end of the M1 to M5 train: InvalidReceipt, disowned_receipt, and any empty-receipt check have zero matches across the videre code (now videre-host and echo-venue, in nullislabs/videre-nexum-module).
Resolve one of:
- restore the empty-receipt rejection (reinstate
VenueError::InvalidReceipt plus the dropped test), or
- document that dropping it is intentional, with the rationale.
Follow-up from review of #428 (comment).
The videre rename dropped the empty-receipt rejection.
status/cancelpreviously rejected an empty receipt withVenueError::InvalidReceipt, anddisowned_receipt_is_dropped_from_the_watchcovered it. Both theInvalidReceiptvariant and the test were removed in the rename rather than adapted, so both paths now succeed unconditionally on any receipt, including empty ones.Confirmed still present at the end of the M1 to M5 train:
InvalidReceipt,disowned_receipt, and any empty-receipt check have zero matches across the videre code (nowvidere-hostandecho-venue, innullislabs/videre-nexum-module).Resolve one of:
VenueError::InvalidReceiptplus the dropped test), or