Global code review

[nono303]

Hi,
As it’s the first httpd module I adapt, I would like a "skilled developers" review to check that all is compliant for a possible future integration in httpd core.

Globally does code style, normalization, compliance, ASF requirement... are actually fulfilled?
This shouldn't take long and I'm thinking especially of:

• @JBlond
• @icing
• @kjdev (as owner of https://github.com/kjdev/php-ext-zstd & https://github.com/kjdev/apache-mod-brotli)
  • Improve ZSTD_compressStream2 from bucket read to stream #6
  • Reusing context for compression #7
  • Multithreading & ZSTD_c_nbWorkers parameter #10

[JBlond]

The license looks good. The code contains the license, too.
mod_zstd.c line lines longer than 80 characters: 94, 115, 423, 450, 474
A doc in XML format would be a plus, like https://github.com/apache/httpd/blob/trunk/docs/manual/mod/mod_actions.xml

[nono303]

The license looks good. The code contains the license, too. mod_zstd.c line lines longer than 80 characters: 94, 115, 423, 450, 474 A doc in XML format would be a plus, like https://github.com/apache/httpd/blob/trunk/docs/manual/mod/mod_actions.xml

I'll take care #8 #9

[icing]

I have not tested this, but the code looks good! As @JBlond noticed, for integration into the apache repository, a documentation xml is needed. But this would be a second step, I guess.

Congrats to doing this!

[JBlond]

I've tested this module since March, and it works fine.