Emulation running too fast

[Morphlng]

I'm trying to use the gameboycore library and using this project as a reference. I cloned the source code, removed the networking part and compiled myself with VS2019+Qt 5.15.2.

However, when it comes to testing/playing, the game is just running too fast. For example, in game Mario the time counts down about 20 in game seconds per real time seconds.

I believe this part of code doesn't do what it supposed to do.

dotrix/include/emu/core_updater.h

Lines 21 to 27 in ea06cad

	void run()
	{
	while (running_)
	{
	core_.update(512);
	}
	}

The screen renders every 16ms, but the cpu cycles never stops. I changed the logic in this part as below, and it runs nearly normal:

void run() 
 { 
 	while (running_) 
 	{ 
 		core_.emulateFrame();
                msleep(16);
 	} 
 } 

Calling thread to sleep still doesn't seems right, I guess a proper signal/slot should be the final solution to this problem.

[nnarain]

Hi, thanks for opening the issue.
It's been many years since I've touched this code. But I believe ::update(...) was the original way I had to update the emulator. Eventually moving to ::emulateFrame. So yes calling emulateFrame every 16ms is the most correct way to do this. I'd agree that doing a timer implementation with signal and slots would be better.