Progress bar bolus increments not rounded to 0.05U anymore after RxBus refactor (Omnipod Dash)

[nl-ruud]

Problem

Commit 9f9f988 (introduced in version 3.4.1.0) appears to have unintentionally changed the progress bar behavior for Omnipod Dash bolus delivery. The Omnipod delivers insulin in increments of 0.05U, but the progress bar now displays values such as 0.02U, 0.04U, 0.07U which are not physically deliverable by the pod.

Expected behavior

Displayed delivered insulin should always align with pod pulse steps (multiples of 0.05U).

Root cause

The commit replaced a direct UI method call with an RxBus event (likely to decouple the pump plugin from the UI). During this change:

• The percent-based constructor was used
• The rounding logic (Round.roundTo(..., 0.05)) was dropped

This results in displaying unrounded fractional values.

Proposed fix

Current:

OmnipodDashPumpPlugin.kt, line 703 and line 731.

rxBus.send(EventOverviewBolusProgress(rh, percent = percent.toInt()));

Proposed:

rxBus.send(EventOverviewBolusProgress(
    rh,
    delivered = Round.roundTo(
        percent * requestedBolusAmount / 100,
        PodConstants.POD_PULSE_BOLUS_UNITS
    )
));

---

@Philoul --- since this change originated from your commit, can you confirm whether this change of behavior was unintended? If so, I can open a PR with the fix above.

[Philoul]

Yes, you can open a PR

[nl-ruud]

@Philoul the proposed fix does fix the issue, but it also hides the cancel button, which isn’t intended.

To address that, I need to use:

rxBus.send(EventOverviewBolusProgress(
    status = rh.gs(
        app.aaps.core.interfaces.R.string.bolus_delivering, 
        Round.roundTo(percent * requestedBolusAmount / 100, 
        PodConstants.POD_PULSE_BOLUS_UNITS)
    ),
    percent = percent.toInt()
))

However, this is exactly what updateBolusProgressDialog did (and does), so I’m effectively reverting your commit.
I assume that’s the correct approach here, but just wanted to confirm.

[Philoul]

No, you should not revert the commit. But change the calculated amount).

Status and string should be managed within EventOverviewBolusProgress and not within Pump driver (here you override the correct management so it create regressions, i.e. in bolus progress popup within watch...).

This call has been modified again for the future AAPS V4.

• it's a minor issue so it will probably not be merged now if you modify the code.

Better to keep it like it is.