Add gcta/addgrms module#10995
Open
lyh970817 wants to merge 3 commits into
Open
Conversation
lyh970817
force-pushed
the
modules/gcta-addgrms-create
branch
from
e685b3b to
c6d78e2
Compare
Contributor
|
Duplicate of #8140 ? @lyh970817 can you check for overlap and if this is a duplicate close the older PR? |
lyh970817
force-pushed
the
modules/gcta-addgrms-create
branch
from
6778e85 to
c3226e0
Compare
SPPearce
reviewed
May 21, 2026
| --make-grm \\ | ||
| --out ${prefix} \\ | ||
| --thread-num ${task.cpus} \\ | ||
| ${extra_args} |
Contributor
There was a problem hiding this comment.
Suggested change
| ${extra_args} | |
| ${args} |
Contributor
Author
There was a problem hiding this comment.
Kept ${args} as the final command line in the cleanup commit so the script stays aligned with nf-core module style.
| def prefix = task.ext.prefix ?: "${meta.id}" | ||
|
|
||
| """ | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removed the extra blank spacer line in 9ecb62d2c.
| task.ext.when == null || task.ext.when | ||
|
|
||
| script: | ||
| def extra_args = task.ext.args ?: '' |
Contributor
There was a problem hiding this comment.
Suggested change
| def extra_args = task.ext.args ?: '' | |
| def args = task.ext.args ?: '' |
Contributor
Author
There was a problem hiding this comment.
Updated in 9ecb62d2c by renaming extra_args to args to match the module convention.
| tag "${meta.id}" | ||
| label 'process_medium' | ||
| conda "${moduleDir}/environment.yml" | ||
| container "${workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container |
Contributor
There was a problem hiding this comment.
Can you swap this to the more recent singularity or apptainer syntax (see other modules)
Contributor
Author
There was a problem hiding this comment.
Addressed in 0f36baf.
lyh970817
force-pushed
the
modules/gcta-addgrms-create
branch
from
363708f to
4191fb4
Compare
lyh970817
force-pushed
the
modules/gcta-addgrms-create
branch
from
4191fb4 to
5962c65
Compare
lyh970817
force-pushed
the
modules/gcta-addgrms-create
branch
from
339f30a to
9ecb62d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
gcta/addgrmsmodule, which combines multiple GRMs listed in an MGRM manifest into a single dense GRM.PR checklist
topic: versions- See version_topicslabelnf-core modules test gcta/addgrms --profile dockernf-core modules test gcta/addgrms --profile singularitynf-core modules test gcta/addgrms --profile conda