Skip to content

fix: urlencode file source based on resource url - #3320

Merged
AndyScherzinger merged 2 commits into
masterfrom
leftybournes/fix/file-url-encoding
Aug 10, 2026
Merged

fix: urlencode file source based on resource url#3320
AndyScherzinger merged 2 commits into
masterfrom
leftybournes/fix/file-url-encoding

Conversation

@leftybournes

Copy link
Copy Markdown
Member

This fixes an issue with some apps like Text where a file isn't removed from the files list when deleted from viewer.

Before

before.webm

After

after.webm

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Comment thread src/views/Viewer.vue Outdated
Signed-off-by: Kent Delante <kent@delante.me>
Assisted-by: ClaudCode:claude-sonnet-5
@leftybournes
leftybournes force-pushed the leftybournes/fix/file-url-encoding branch from c32302c to bd97742 Compare August 7, 2026 13:28
@leftybournes

Copy link
Copy Markdown
Member Author

/compile

@leftybournes

Copy link
Copy Markdown
Member Author

/backport bd97742 to stable34

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Aug 7, 2026
@leftybournes

Copy link
Copy Markdown
Member Author

/backport bd97742 to stable33

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@leftybournes
leftybournes enabled auto-merge August 7, 2026 13:58
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Aug 7, 2026
@leftybournes

Copy link
Copy Markdown
Member Author

The failing tests aren't related. I'm getting the same failures while running the tests in a local vm on master.

@AndyScherzinger AndyScherzinger added this to the Nextcloud 35 milestone Aug 10, 2026
@AndyScherzinger
AndyScherzinger merged commit 9707694 into master Aug 10, 2026
19 of 25 checks passed
@AndyScherzinger
AndyScherzinger deleted the leftybournes/fix/file-url-encoding branch August 10, 2026 10:59
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Aug 10, 2026
@leftybournes

Copy link
Copy Markdown
Member Author

/backport bd97742 to stable32

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Aug 10, 2026
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants