Embedded and shared tables do not respect the view column order

[Aveyron-RetD]

Steps to reproduce

1. Have a view with column ordering (not default ordering)
2. Share this view or embed the view
3. Look at the response

Expected behavior

Column ordering is respected

Actual behavior

Column ordering is not respected

Tables app version

2.1.1

Browser

Firefox 150

Client operating system

Windows

Operating system

No response

Web server

None

PHP engine version

None

Database

None

Additional info

I believe sorting is the same also....

=> Original View

=> Shared View

=> Embedded

[Aveyron-RetD]

AI suggest to patch Columservice.php function findAllByManagedView with

public function findAllByManagedView(View $view, string $userId): array {
    if (!$this->permissionsService->canManageView($view, $userId)) {
        throw new PermissionError('no manage access to view id = ' . $view->getId());
    }

    try {
        // 1. load table columns
        $columns = $this->mapper->findAllByTable($view->getTableId());

        // 2. load view column settings
        $settings = $view->getColumnsSettingsArray(); // array of ViewColumnInformation

        if ($settings && count($settings) > 0) {
            // index columns by id
            $byId = [];
            foreach ($columns as $col) {
                $byId[$col->getId()] = $col;
            }

            // sort settings by order
            usort(
                $settings,
                static fn (ViewColumnInformation $a, ViewColumnInformation $b) =>
                    $a->getOrder() <=> $b->getOrder()
            );

            $ordered = [];

            // 3. apply explicit view order
            foreach ($settings as $info) {
                $id = $info->getId();
                if (isset($byId[$id])) {
                    $ordered[] = $byId[$id];
                    unset($byId[$id]);
                }
            }

            // 4. append remaining columns (not explicitly ordered)
            foreach ($byId as $col) {
                $ordered[] = $col;
            }

            // 5. enhance and return
            return $this->enhanceColumns($ordered, $view);
        }

        // fallback: no settings → default behavior
        return $this->enhanceColumns($columns, $view);

    } catch (\OCP\DB\Exception $e) {
        $this->logger->error($e->getMessage(), ['exception' => $e]);
        throw new InternalError(get_class($this) . ' - ' . __FUNCTION__ . ': ' . $e->getMessage());
    }
}

AI stuff
🎉 What this fixes

After this patch:

Shared views respect column order

Public link shares respect column order

Embeds (/content) respect column order

Internal view switching respects column order

No changes needed in ViewService, RowService, or frontend

Because every place that loads columns for a view already calls findAllByManagedView().

[AndyScherzinger]

@Aveyron-RetD fancy providing a PR? 😃

[Aveyron-RetD]

Well it's all AI suggested and tested in real, and I am struggling badly with #2597.
If this fix works i will submit it

[AndyScherzinger]

If this fix works i will submit it

Ah, erm, to clarify - I read your message as "this fixes it" as in it is tested and works for you or is this just the AI output suggesting it it does?

[Aveyron-RetD]

It is just AI slop but i will test it 🙏 and submit it if it works. Sorry if my reply was not comprehensible.

I am a new kind of contributor ===> tell me if that is not useful => With the help of AI, I can now narrow bugs and try to find some suggestion.

Normally I try to find one-liner for easy fix
nextcloud/calendar#8157
nextcloud/mail#12907

I am now able to test my suggestion so I try to fix stuff a little be more complicated.
nextcloud/calendar#8083

[taiebot]

Well home time so i am testing this and 💩 . will investigate more

[Aveyron-RetD]

to try another thing tonight from claude AI. Claude AI is 🤯 or very convincing. Found the stuff by just linking to this bug report...
to be added to finAllbyview

$columnIds = $view->getColumnIds();
$viewColumns = $this->mapper->findAll($columnIds);

// Sort columns to match the view's configured column order.
usort($viewColumns, static function ($a, $b) use ($columnIds): int {
    return array_search($a->getId(), $columnIds, true)
            <=> array_search($b->getId(), $columnIds, true);
});

return $this->enhanceColumns($viewColumns, $view);