fix(files_sharing): Hide incompatible actions in pending and deleted share views

Pending and deleted share entries are not mounted into the user's
filesystem, so generic file operations like delete or download cannot
succeed and produce a misleading "file is not available" error.

These views now expose only the actions that actually apply: accept and
reject for pending shares; restore for deleted shares. All other views
continue to show every registered action.

Author: nfebe

apps/files/src/components/FileEntryMixin.ts

@@ -18,6 +18,7 @@ import { extname, relative } from 'path'
 import Vue, { computed, defineComponent } from 'vue'
 import { action as sidebarAction } from '../actions/sidebarAction.ts'
 import { onDropInternalFiles } from '../services/DropService.ts'
+import { isActionAllowedInView } from '../services/ViewActionsRegistry.ts'
 import { getDragAndDropPreview } from '../utils/dragUtils.ts'
 import { hashCode } from '../utils/hashUtils.ts'
 import { logger } from '../utils/logger.ts'
@@ -233,6 +234,7 @@ export default defineComponent({
 			}
 
 			return this.actions
+				.filter((action: IFileAction) => isActionAllowedInView(this.activeView?.id, action.id))
 				.filter((action: IFileAction) => {
 					if (!action.enabled) {
 						return true

apps/files/src/components/FilesListTableHeaderActions.vue

@@ -93,6 +93,7 @@ import { useActionsMenuStore } from '../store/actionsmenu.ts'
 import { useActiveStore } from '../store/active.ts'
 import { useFilesStore } from '../store/files.ts'
 import { useSelectionStore } from '../store/selection.ts'
+import { isActionAllowedInView } from '../services/ViewActionsRegistry.ts'
 import { logger } from '../utils/logger.ts'
 
 export const FILE_LIST_HEAD_FIRST_BATCH_ACTION_ID = 'files-list-head-first-batch-action'
@@ -167,6 +168,8 @@ export default defineComponent({
 	computed: {
 		enabledFileActions(): IFileAction[] {
 			return this.actions
+				// Actions can be restricted per-view (e.g. pending shares only allow accept/reject)
+				.filter((action) => isActionAllowedInView(this.currentView?.id, action.id))
 				// We don't handle renderInline actions in this component
 				.filter((action) => !action.renderInline)
 				// We don't handle actions that are not visible

apps/files/src/services/ViewActionsRegistry.spec.ts

@@ -0,0 +1,45 @@
+/*!
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import { describe, expect, it } from 'vitest'
+import { isActionAllowedInView, restrictViewActions } from './ViewActionsRegistry.ts'
+
+describe('ViewActionsRegistry', () => {
+	it('allows any action in views that have not been restricted', () => {
+		expect(isActionAllowedInView('unrestricted-view', 'delete')).toBe(true)
+		expect(isActionAllowedInView('unrestricted-view', 'download')).toBe(true)
+	})
+
+	it('allows any action when no view is active', () => {
+		expect(isActionAllowedInView(undefined, 'delete')).toBe(true)
+	})
+
+	it('only allows actions in the allowlist for restricted views', () => {
+		restrictViewActions('pendingshares', ['accept-share', 'reject-share'])
+
+		expect(isActionAllowedInView('pendingshares', 'accept-share')).toBe(true)
+		expect(isActionAllowedInView('pendingshares', 'reject-share')).toBe(true)
+		expect(isActionAllowedInView('pendingshares', 'delete')).toBe(false)
+		expect(isActionAllowedInView('pendingshares', 'download')).toBe(false)
+		expect(isActionAllowedInView('pendingshares', 'sharing-status')).toBe(false)
+	})
+
+	it('does not affect siblings when one view is restricted', () => {
+		restrictViewActions('deletedshares', ['restore-share'])
+
+		expect(isActionAllowedInView('deletedshares', 'restore-share')).toBe(true)
+		expect(isActionAllowedInView('deletedshares', 'delete')).toBe(false)
+		// A sibling view that has not been restricted is still wide open.
+		expect(isActionAllowedInView('files', 'delete')).toBe(true)
+	})
+
+	it('replaces the allowlist when called twice for the same view', () => {
+		restrictViewActions('view-a', ['action-1'])
+		restrictViewActions('view-a', ['action-2'])
+
+		expect(isActionAllowedInView('view-a', 'action-1')).toBe(false)
+		expect(isActionAllowedInView('view-a', 'action-2')).toBe(true)
+	})
+})

apps/files/src/services/ViewActionsRegistry.ts

@@ -0,0 +1,37 @@
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+const allowlists = new Map<string, ReadonlySet<string>>()
+
+/**
+ * Restrict the file actions exposed in a given view to the listed action IDs.
+ *
+ * Useful for views that list metadata rather than mounted filesystem entries
+ * (pending shares, deleted shares), where generic file operations cannot
+ * succeed and produce a misleading "file is not available" error.
+ *
+ * Default (view never registered here): all actions are candidates.
+ * The action's own `enabled()` predicate still applies on top.
+ *
+ * @param viewId - The view to restrict
+ * @param actionIds - The IDs of the only actions allowed in that view
+ */
+export function restrictViewActions(viewId: string, actionIds: readonly string[]): void {
+	allowlists.set(viewId, new Set(actionIds))
+}
+
+/**
+ * Check if the given action is allowed in the given view.
+ *
+ * @param viewId - The view ID, or undefined when no view is active
+ * @param actionId - The action ID
+ */
+export function isActionAllowedInView(viewId: string | undefined, actionId: string): boolean {
+	if (viewId === undefined) {
+		return true
+	}
+	const allowlist = allowlists.get(viewId)
+	return allowlist === undefined || allowlist.has(actionId)
+}

apps/files/src/utils/actionUtils.ts

@@ -8,6 +8,7 @@ import { showError, showSuccess } from '@nextcloud/dialogs'
 import { NodeStatus } from '@nextcloud/files'
 import { t } from '@nextcloud/l10n'
 import Vue from 'vue'
+import { isActionAllowedInView } from '../services/ViewActionsRegistry.ts'
 import { useActiveStore } from '../store/active.ts'
 import { logger } from '../utils/logger.ts'
 
@@ -41,6 +42,11 @@ export async function executeAction(action: IFileAction) {
 		contents,
 	} as ActionContextSingle
 
+	if (!isActionAllowedInView(currentView.id, action.id)) {
+		logger.debug('Action is not allowed in the current view', { action, view: currentView })
+		return
+	}
+
 	if (!action.enabled!(context)) {
 		logger.debug('Action is not not available for the current context', { action, node: currentNode, view: currentView })
 		return

apps/files_sharing/src/files_views/shares.ts

@@ -14,6 +14,7 @@ import { getNavigation, View } from '@nextcloud/files'
 import { loadState } from '@nextcloud/initial-state'
 import { t } from '@nextcloud/l10n'
 import { ShareType } from '@nextcloud/sharing'
+import { restrictViewActions } from '../../../files/src/services/ViewActionsRegistry.ts'
 import { getContents, isFileRequest } from '../services/SharingService.ts'
 
 export const sharesViewId = 'shareoverview'
@@ -137,6 +138,11 @@ export default () => {
 		getContents: () => getContents(false, false, false, true),
 	}))
 
+	// Deleted shares are unmounted: only "restore" can succeed.
+	// Generic file actions would call DAV against an unreachable path
+	// and surface a misleading "file is not available" error.
+	restrictViewActions(deletedSharesViewId, ['restore-share'])
+
 	Navigation.register(new View({
 		id: pendingSharesViewId,
 		name: t('files_sharing', 'Pending shares'),
@@ -153,4 +159,7 @@ export default () => {
 
 		getContents: () => getContents(false, false, true, false),
 	}))
+
+	// Pending shares are not yet mounted: only "accept" / "reject" can succeed.
+	restrictViewActions(pendingSharesViewId, ['accept-share', 'reject-share'])
 }