No access to Team folders created with option "Do not grant any advanced permissions by default"

[jonasv1]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps to reproduce

1. Create new Team folder with option «Do not grant any advanced permissions by default», share with group (write/share/delete) and activate Advanced Permissions.

2. Add new Advanced permission rule for group: allow read/write/create/delete

3. Try to upload / create a new file or folder in this Team folder, as a member of the group with read/write/create/delete rights via Advanced permissions.

Expected behaviour

I should be able to upload and create new files or folders.

Actual behaviour

It is not possible to upload / create a new file or folder.

Server configuration

Nextcloud version: 33.0.0

Team folders version: 21.0.6

Updated from an older Nextcloud/ownCloud or fresh install: fresh install

Are you using encryption: no

[jonasjelonek]

This needs a fix in the stable branch or however. I ran Claude over this and it suggested the following change:

diff --git a/lib/Mount/MountProvider.php b/lib/Mount/MountProvider.php
index 891f7043..1a332d4e 100644
--- a/lib/Mount/MountProvider.php
+++ b/lib/Mount/MountProvider.php
@@ -307,7 +307,7 @@ class MountProvider implements IMountProvider, IPartialMountProvider {
                                $loader,
                                $user,
                                $aclManager,
-                               $folder->acl ? $aclManager->getRulesByFileIds([$folder->rootId]) : [],
+                               $folder->acl ? $aclManager->getRulesByFileIds([$folder->rootId])[$folder->storageId] ?? [] : [],
                        );
                }

And I can confirm this works on a running instance with Nextcloud 33.0.1.

@nickvergessen @provokateurin Might one of you take care of such a backport? I would have to fill the PR and commit description what Claude explained to me, and it's not really a backport due to the large commit this change was part of in master branch.
How about a new release then so this fix gets official?

[nickvergessen]

I'm not affiliated with this app

[provokateurin]

Fix is at #4564. This was already fixed on master, but forgotten to backport to stable33.

[jonasjelonek]

Fix is at #4564. This was already fixed on master, but forgotten to backport to stable33.

Thank you!