Skip to content

feat(translations): validate non-breaking space before ellipsis#820

Open
ShGKme wants to merge 1 commit into
masterfrom
feat/translations--non-breaking-space-before-ellipsis
Open

feat(translations): validate non-breaking space before ellipsis#820
ShGKme wants to merge 1 commit into
masterfrom
feat/translations--non-breaking-space-before-ellipsis

Conversation

@ShGKme

@ShGKme ShGKme commented Aug 25, 2025

Copy link
Copy Markdown

No description provided.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme requested review from nickvergessen and susnux August 25, 2025 19:30
@ShGKme ShGKme self-assigned this Aug 25, 2025

@nickvergessen nickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will have to fix spreed and server before merging and recreating the new image. Planning to do that on Friday

@rakekniven

Copy link
Copy Markdown
Member

@nickvergessen Does this mean that you make a large commit that inserts a non-breaking space if required?

How to apply this to all other apps?
Should we then also integrate this into our guidelines?

@nickvergessen

Copy link
Copy Markdown
Member

Should we then also integrate this into our guidelines?

Does this mean that you make a large commit that inserts a non-breaking space if required?

I guess so, or you have a better idea?

@rakekniven

Copy link
Copy Markdown
Member

I guess so, or you have a better idea?

No, just wanted to make sure my understanding is correct.

@nickvergessen

nickvergessen commented Aug 29, 2025

Copy link
Copy Markdown
Member

PHPStorm regex search and replace:

[^\x{00A0}]…'\)
 …')

@nickvergessen

Copy link
Copy Markdown
Member

hmpf, we need to do this on all translated branches and it basically means when a translator doesn't revisit the language strings before the next maintenance release we break things again 🙈

Maybe hardcoding this in the t() functions isn't that bad of an idea after all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants