Skip to content

Keep connection alive for body-less responses (204) to avoid ECONNRESET on keep-alive clients #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
icebob wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep connection alive for body-less responses (204) to avoid ECONNRESET on keep-alive clients #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/main/java/services/moleculer/web/netty/NettyWebResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,20 @@ public void send(byte[] bytes) throws IOException {
*/
@Override
public boolean end() {

// If no response body has been written (e.g. "204 No Content", or an
// action that returned null), the response is complete with zero
// length. Emit an explicit "Content-Length: 0" so the message is
// properly framed and the keep-alive connection can be reused. Without
// it, the block below closes the channel (no Content-Length is present)
// but no "Connection: close" header is sent, so pooled HTTP clients
// (browsers, Node http.Agent/axios, ...) reuse the socket and fail the
// next request with "ECONNRESET" / "socket hang up".
if (first.get() && (req == null || req.parser == null)
&& (headers == null || headers.get(CONTENT_LENGTH) == null)) {
setHeader(CONTENT_LENGTH, "0");
}

sendHeaders();
if (req != null && req.parser != null) {
try {
Expand Down