From c2c4a819c096730b73e7a769dda3e9e2869ba901 Mon Sep 17 00:00:00 2001
From: Artur Shiriev <lesnik512@gmail.com>
Date: Sun, 31 May 2026 23:37:09 +0300
Subject: [PATCH] fix: shut down TracerProvider in
 OpenTelemetryInstrument.teardown
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The instrument's bootstrap() created a TracerProvider, registered span
processors against it, and called set_tracer_provider — but never stored
a reference. teardown() only uninstrumented the instrumentors; the
provider was never shut down. Spans buffered in BatchSpanProcessor were
lost on graceful shutdown.

Stash the provider on the instrument via object.__setattr__ (mirroring
the LoggingInstrument._logger_factory pattern for runtime state on a
frozen dataclass), shut it down after the uninstrument loop, reset the
field to None so a subsequent bootstrap starts clean.

Regression test asserts shutdown is called exactly once on the stored
provider and the field is reset.

Closes CRIT-2, TEST-2 from the audit.
---
 .../instruments/opentelemetry_instrument.py     |  7 +++++++
 .../test_opentelemetry_instrument.py            | 17 +++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/lite_bootstrap/instruments/opentelemetry_instrument.py b/lite_bootstrap/instruments/opentelemetry_instrument.py
index 9c3ef30..bbd9fa1 100644
--- a/lite_bootstrap/instruments/opentelemetry_instrument.py
+++ b/lite_bootstrap/instruments/opentelemetry_instrument.py
@@ -78,6 +78,9 @@ class OpenTelemetryInstrument(BaseInstrument):
     bootstrap_config: OpentelemetryConfig
     not_ready_message = "opentelemetry_endpoint is empty and opentelemetry_log_traces is False"
     missing_dependency_message = "opentelemetry is not installed"
+    _tracer_provider: "TracerProvider | None" = dataclasses.field(
+        default_factory=lambda: None, init=False, repr=False, compare=False
+    )
 
     def is_ready(self) -> bool:
         return (
@@ -105,6 +108,7 @@ def bootstrap(self) -> None:
         )
         tracer_provider = TracerProvider(resource=resource)
         set_tracer_provider(tracer_provider)
+        object.__setattr__(self, "_tracer_provider", tracer_provider)
         if import_checker.is_pyroscope_installed and getattr(self.bootstrap_config, "pyroscope_endpoint", None):
             tracer_provider.add_span_processor(PyroscopeSpanProcessor())
         if self.bootstrap_config.opentelemetry_log_traces:
@@ -133,3 +137,6 @@ def teardown(self) -> None:
                 one_instrumentor.instrumentor.uninstrument(**one_instrumentor.additional_params)
             else:
                 one_instrumentor.uninstrument()
+        if self._tracer_provider is not None:
+            self._tracer_provider.shutdown()
+            object.__setattr__(self, "_tracer_provider", None)
diff --git a/tests/instruments/test_opentelemetry_instrument.py b/tests/instruments/test_opentelemetry_instrument.py
index 0fbccd7..3f3e68b 100644
--- a/tests/instruments/test_opentelemetry_instrument.py
+++ b/tests/instruments/test_opentelemetry_instrument.py
@@ -1,3 +1,5 @@
+from unittest.mock import patch
+
 from lite_bootstrap.instruments.opentelemetry_instrument import (
     InstrumentorWithParams,
     OpentelemetryConfig,
@@ -32,3 +34,18 @@ def test_opentelemetry_instrument_empty_instruments() -> None:
         opentelemetry_instrument.bootstrap()
     finally:
         opentelemetry_instrument.teardown()
+
+
+def test_opentelemetry_instrument_teardown_shuts_down_tracer_provider() -> None:
+    instrument = OpenTelemetryInstrument(
+        bootstrap_config=OpentelemetryConfig(opentelemetry_log_traces=True),
+    )
+    instrument.bootstrap()
+    tracer_provider = instrument._tracer_provider  # noqa: SLF001
+    assert tracer_provider is not None
+
+    with patch.object(tracer_provider, "shutdown") as mock_shutdown:
+        instrument.teardown()
+
+    mock_shutdown.assert_called_once_with()
+    assert instrument._tracer_provider is None  # noqa: SLF001