docs: correct Wingman's gateway CORS requirements#2
Merged
Conversation
The cross-origin section was wrong on two counts: it said the Manifest backend allows Wingman "out of the box" (it's dev-only), and it listed only three allowed headers. The agent and SDK profiles send X-Stainless-* headers the list omitted, so following the docs reproduced a CORS preflight failure. - Say the backend allows the Wingman origin in dev mode only - List the X-Stainless-* headers, recommend reflecting request headers - Note the Private Network Access header for loopback gateways over HTTPS
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💭 Why
The cross-origin section was wrong on two counts. It said the Manifest backend allows Wingman "out of the box" (it's dev-only), and it listed only three allowed headers. The agent and SDK profiles send
X-Stainless-*headers the list omitted, so following the docs reproduced a CORS preflight failure.✨ What changed
X-Stainless-*headers, and recommend reflectingAccess-Control-Request-Headers.📝 Notes
Backend dev-CORS fix that this documents: mnfst/manifest#1970.