Environment
- modda v1.11.0 (x86_64-unknown-linux-musl, precompiled binary)
- WeiDU v251.00
- Baldur's Gate II: Enhanced Edition, native Linux build (GOG via Heroic)
Description
The log message "dry run done with no error" appears at the end of an
install run even when --dry-run was not passed — i.e. a real install
that actually invokes WeiDU and patches files.
Reproduction
Run any real install, e.g.:
modda install --manifest-path modpack.yaml
The manifest doesn't matter — this has been observed across several
distinct test sessions:
- a single-module manifest (1 mod, 4 components)
- a multi-module manifest (5 mods, 79 components total)
- a partial install via
--from-index
In every case, weidu.log is correctly generated, files are genuinely
patched, and the install has fully succeeded — the message just misreports
the run type.
Expected
On a real install, the closing message should read something like
"Installation done with no error" (as it sometimes does — see below),
not the dry-run wording.
Actual
"dry run done with no error" shows up on real installs too, seemingly at
random. I haven't been able to find a factor that reliably predicts which
message appears — module count, use of --from-index, and whether all
components installed successfully don't seem to correlate.
Impact
Cosmetic only as far as I can tell — the actual install behavior (files
patched, weidu.log content, reproducibility across runs) is correct
regardless of which message is shown. But it's confusing for anyone
relying on the log output to confirm a real install actually ran (e.g. in
a scripted/CI context).
Happy to provide more repro detail or test a patch if useful.
Environment
Description
The log message
"dry run done with no error"appears at the end of aninstall run even when
--dry-runwas not passed — i.e. a real installthat actually invokes WeiDU and patches files.
Reproduction
Run any real install, e.g.:
The manifest doesn't matter — this has been observed across several
distinct test sessions:
--from-indexIn every case,
weidu.logis correctly generated, files are genuinelypatched, and the install has fully succeeded — the message just misreports
the run type.
Expected
On a real install, the closing message should read something like
"Installation done with no error"(as it sometimes does — see below),not the dry-run wording.
Actual
"dry run done with no error"shows up on real installs too, seemingly atrandom. I haven't been able to find a factor that reliably predicts which
message appears — module count, use of
--from-index, and whether allcomponents installed successfully don't seem to correlate.
Impact
Cosmetic only as far as I can tell — the actual install behavior (files
patched, weidu.log content, reproducibility across runs) is correct
regardless of which message is shown. But it's confusing for anyone
relying on the log output to confirm a real install actually ran (e.g. in
a scripted/CI context).
Happy to provide more repro detail or test a patch if useful.