From 2f7e3c171ff2318914c0424a5c5f1fafb07911d7 Mon Sep 17 00:00:00 2001 From: Davis Goodin Date: Thu, 9 Jul 2026 13:33:56 -0700 Subject: [PATCH] Revert "Ship .asc signature alongside .sig (#2348) (#2404)" This reverts commit 4872fbccffd9ad728d2134956daf8df18b139211. --- eng/_util/cmd/sign/archive.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/eng/_util/cmd/sign/archive.go b/eng/_util/cmd/sign/archive.go index 67d9bee5a34..5eb3865825b 100644 --- a/eng/_util/cmd/sign/archive.go +++ b/eng/_util/cmd/sign/archive.go @@ -431,10 +431,10 @@ func (a *archive) prepareArchiveSignatures(ctx context.Context) ([]*fileToSign, if err := ctx.Err(); err != nil { return nil, err } - // Copy the archive file and add a ".sig" suffix. The signing process sends this new file to get a - // signature, then replaces its content in-place with the result. We need to preemptively make - // a renamed copy of the file so we end up with both the original file and signature on the - // machine. + // Copy the archive file to have .sig suffix, e.g. "tar.gz" to "tar.gz.sig". The signing + // process sends the "tar.gz.sig" file to get a signature, then replaces the "tar.gz.sig" + // file's content in-place with the result. We need to preemptively make a renamed copy of the + // file so we end up with both the original file and sig on the machine. log.Printf("Copying file for signature generation: %q -> %q", a.latestPath(), a.sigPath()) if err := copyFile(a.sigPath(), a.latestPath()); err != nil { return nil, err @@ -464,10 +464,6 @@ func (a *archive) copyToDestination(ctx context.Context) error { if err := copyFile(filepath.Join(*destinationDir, a.name+".sig"), a.sigPath()); err != nil { return err } - // Also produce an .asc file (same content) to match upstream Go's convention. - if err := copyFile(filepath.Join(*destinationDir, a.name+".asc"), a.sigPath()); err != nil { - return err - } return nil }