Fix SchemaDocument being called with the wrong number of arguments.#169
Closed
pawREP wants to merge 1 commit into
Closed
Fix SchemaDocument being called with the wrong number of arguments.#169pawREP wants to merge 1 commit into
pawREP wants to merge 1 commit into
Conversation
Contributor
|
This is probably due to the rapidjson version that we have under External/RapidJSON/CMakeRapidJSONDownload.txt.in, in order for this to work we will probably need to update it to use the latest version of rapidjson. |
Contributor
Author
|
This issue originated from a misconfiguration on my system. My project had pulled in an outdated version of rapidjson. Case close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121
Mirroring my comment on the issue here for visibility.
The current code doesn't compile because of bad arguments. There is no 4 parameter constructor for SchemaDocument and there never was one in previous rapidjson versions either. Looking at 9428f11, where this issue was introduced, it seems like someone tried to change the call from SchemaDocument(document, this) to SchemaDocument(document, nullptr, 0) when the rapidjson version was bumped but forgot to remove the "this". That would at least be syntactically correct but still logically false and results in test failures.