From 024b5c5953d94a25ef84df06643c6536aaeb9cdc Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Tue, 11 Mar 2025 11:55:25 -0700 Subject: [PATCH 1/9] forgot to add the file last time --- protos/orchestrator_service.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index 64e7528..e44a7e3 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -487,6 +487,7 @@ message SignalEntityRequest { google.protobuf.StringValue input = 3; string requestId = 4; google.protobuf.Timestamp scheduledTime = 5; + TraceContext parentTraceContext = 6; } message SignalEntityResponse { From 9229787faf86f62fd3288e3ce5120ffedb7618cf Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Sun, 23 Mar 2025 18:01:46 -0700 Subject: [PATCH 2/9] added new fields related to entities signaling other entities or starting orchestrations, as well as for operation requests for entities --- protos/orchestrator_service.proto | 3 +++ 1 file changed, 3 insertions(+) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index e44a7e3..3da0fe1 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -573,6 +573,7 @@ message OperationRequest { string operation = 1; string requestId = 2; google.protobuf.StringValue input = 3; + TraceContext TraceContext = 4; } message OperationResult { @@ -608,6 +609,7 @@ message SendSignalAction { string name = 2; google.protobuf.StringValue input = 3; google.protobuf.Timestamp scheduledTime = 4; + TraceContext parentTraceContext = 5; } message StartNewOrchestrationAction { @@ -616,6 +618,7 @@ message StartNewOrchestrationAction { google.protobuf.StringValue version = 3; google.protobuf.StringValue input = 4; google.protobuf.Timestamp scheduledTime = 5; + TraceContext parentTraceContext = 6; } service TaskHubSidecarService { From 2dbd2bcb612871d8ecfeaef5f20a4b5872cd5769 Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Mon, 24 Mar 2025 00:48:21 -0700 Subject: [PATCH 3/9] testing a change --- protos/orchestrator_service.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index 3da0fe1..3a01e67 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -574,6 +574,7 @@ message OperationRequest { string requestId = 2; google.protobuf.StringValue input = 3; TraceContext TraceContext = 4; + string TraceParent = 5; } message OperationResult { From 879660b7c91e100fdc9c9bc378b04b58da7673e4 Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Mon, 24 Mar 2025 13:42:07 -0700 Subject: [PATCH 4/9] adding several more fields related to start and end times --- protos/orchestrator_service.proto | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index 3a01e67..72bd9bf 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -574,7 +574,6 @@ message OperationRequest { string requestId = 2; google.protobuf.StringValue input = 3; TraceContext TraceContext = 4; - string TraceParent = 5; } message OperationResult { @@ -591,10 +590,14 @@ message OperationInfo { message OperationResultSuccess { google.protobuf.StringValue result = 1; + google.protobuf.Timestamp startTime = 2; + google.protobuf.Timestamp endTime = 3; } message OperationResultFailure { TaskFailureDetails failureDetails = 1; + google.protobuf.Timestamp startTime = 2; + google.protobuf.Timestamp endTime = 3; } message OperationAction { @@ -610,7 +613,8 @@ message SendSignalAction { string name = 2; google.protobuf.StringValue input = 3; google.protobuf.Timestamp scheduledTime = 4; - TraceContext parentTraceContext = 5; + google.protobuf.Timestamp requestTime = 5; + TraceContext parentTraceContext = 6; } message StartNewOrchestrationAction { @@ -619,7 +623,8 @@ message StartNewOrchestrationAction { google.protobuf.StringValue version = 3; google.protobuf.StringValue input = 4; google.protobuf.Timestamp scheduledTime = 5; - TraceContext parentTraceContext = 6; + google.protobuf.Timestamp requestTime = 6; + TraceContext parentTraceContext = 7; } service TaskHubSidecarService { From 36e201ae2972fe86d42c19c7bc463c52243e39d9 Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Mon, 24 Mar 2025 16:01:47 -0700 Subject: [PATCH 5/9] removing an unused field --- protos/orchestrator_service.proto | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index 72bd9bf..a7f8217 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -590,14 +590,12 @@ message OperationInfo { message OperationResultSuccess { google.protobuf.StringValue result = 1; - google.protobuf.Timestamp startTime = 2; - google.protobuf.Timestamp endTime = 3; + google.protobuf.Timestamp endTime = 2; } message OperationResultFailure { TaskFailureDetails failureDetails = 1; - google.protobuf.Timestamp startTime = 2; - google.protobuf.Timestamp endTime = 3; + google.protobuf.Timestamp endTime = 2; } message OperationAction { From c3ba3cbd50904b16357ca747d0ab6f1b7aca7602 Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Thu, 27 Mar 2025 20:15:09 -0700 Subject: [PATCH 6/9] misnamed one field --- protos/orchestrator_service.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index a7f8217..a1eae17 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -573,7 +573,7 @@ message OperationRequest { string operation = 1; string requestId = 2; google.protobuf.StringValue input = 3; - TraceContext TraceContext = 4; + TraceContext traceContext = 4; } message OperationResult { From 82fe7552983e7eaf79418bf8a07121f4fe9d20d2 Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Sun, 13 Apr 2025 17:48:54 -0700 Subject: [PATCH 7/9] added request times to signal entity and create orchestration requests --- protos/orchestrator_service.proto | 2 ++ 1 file changed, 2 insertions(+) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index a1eae17..4054bfe 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -341,6 +341,7 @@ message CreateInstanceRequest { google.protobuf.StringValue executionId = 7; map tags = 8; TraceContext parentTraceContext = 9; + google.protobuf.Timestamp requestTime = 10; } message OrchestrationIdReusePolicy { @@ -488,6 +489,7 @@ message SignalEntityRequest { string requestId = 4; google.protobuf.Timestamp scheduledTime = 5; TraceContext parentTraceContext = 6; + google.protobuf.Timestamp requestTime = 7; } message SignalEntityResponse { From 7198cec93e12484e6c4e69284aabb9cba7068adf Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Fri, 25 Apr 2025 14:34:58 -0700 Subject: [PATCH 8/9] adding a start time to the entity operation result object --- protos/orchestrator_service.proto | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index 4054bfe..57a89e9 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -592,12 +592,14 @@ message OperationInfo { message OperationResultSuccess { google.protobuf.StringValue result = 1; - google.protobuf.Timestamp endTime = 2; + google.protobuf.Timestamp startTime = 2; + google.protobuf.Timestamp endTime = 3; } message OperationResultFailure { TaskFailureDetails failureDetails = 1; - google.protobuf.Timestamp endTime = 2; + google.protobuf.Timestamp startTime = 2; + google.protobuf.Timestamp endTime = 3; } message OperationAction { From 23ed998d1813577d9821e51ea7909063eb677a1b Mon Sep 17 00:00:00 2001 From: Sophia Tevosyan Date: Thu, 15 May 2025 21:19:48 -0700 Subject: [PATCH 9/9] changed startTime and endTime to startTimeUtc and endTimeUtc --- protos/orchestrator_service.proto | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/protos/orchestrator_service.proto b/protos/orchestrator_service.proto index d4a867a..6e41c58 100644 --- a/protos/orchestrator_service.proto +++ b/protos/orchestrator_service.proto @@ -595,14 +595,14 @@ message OperationInfo { message OperationResultSuccess { google.protobuf.StringValue result = 1; - google.protobuf.Timestamp startTime = 2; - google.protobuf.Timestamp endTime = 3; + google.protobuf.Timestamp startTimeUtc = 2; + google.protobuf.Timestamp endTimeUtc = 3; } message OperationResultFailure { TaskFailureDetails failureDetails = 1; - google.protobuf.Timestamp startTime = 2; - google.protobuf.Timestamp endTime = 3; + google.protobuf.Timestamp startTimeUtc = 2; + google.protobuf.Timestamp endTimeUtc = 3; } message OperationAction {