From a799cddb289ed9d7dfacdcced0bc252eb211ed25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A1ra=20Roseck=C3=A1?= Date: Tue, 19 Aug 2025 11:18:40 +0200 Subject: [PATCH] Fix pch file name option format in EnableSecureSourceCodeHashing rule --- .../PERules/BA2004.EnableSecureSourceCodeHashing.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BinSkim.Rules/PERules/BA2004.EnableSecureSourceCodeHashing.cs b/src/BinSkim.Rules/PERules/BA2004.EnableSecureSourceCodeHashing.cs index 3f2a57d0a..e9cfaf5ab 100644 --- a/src/BinSkim.Rules/PERules/BA2004.EnableSecureSourceCodeHashing.cs +++ b/src/BinSkim.Rules/PERules/BA2004.EnableSecureSourceCodeHashing.cs @@ -154,7 +154,7 @@ public void AnalyzeNativeBinaryAndPdb(BinaryAnalyzerContext context) if (omDetails.GetOptionValue(pchOptionSwitches, OrderOfPrecedence.FirstWins, ref pchHeaderFile) == true) { // Now check to see if a pch file name was specified using /Fp: - string[] pchFileNameOptions = { "/Fp:" }; + string[] pchFileNameOptions = { "/Fp" }; if (omDetails.GetOptionValue(pchFileNameOptions, OrderOfPrecedence.FirstWins, ref pchFileName) != true) { // no pch filename specified, so the filename defaults to the pchHeaderFile with the extension swapped to ".pch"