[release/13.2] Updated to cache pfx dev certs on Windows and Linux to avoid binary level changes between runs (#15774)

* Updated to cache pfx dev certs on Windows and Linux to avoid binary changes in persistent container usage

* Fix garbled line

* Update src/Aspire.Hosting/DeveloperCertificateService.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: David Negstad <David.Negstad@microsoft.com>
Co-authored-by: David Negstad <50252651+danegsta@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

src/Aspire.Hosting/DeveloperCertificateService.cs

@@ -193,7 +193,7 @@ private static IEnumerable<X509Certificate2> FindDevCertificates(X509Store store
     }
 
     // Well-known location on disk where dev-cert key material is cached on macOS.
-    private static readonly string s_macOSUserDevCertificateLocation = Path.Combine(
+    private static readonly string s_userDevCertificateLocation = Path.Combine(
         Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".aspire", "dev-certs", "https");
 
     private static readonly SemaphoreSlim s_certificateCacheSemaphore = new(1, 1);
@@ -257,13 +257,12 @@ private static IEnumerable<X509Certificate2> FindDevCertificates(X509Store store
         CancellationToken cancellationToken)
     {
         char[]? pemKey = null;
-        var keyFileName = Path.Join(s_macOSUserDevCertificateLocation, $"{lookup}.key");
+        var keyFileName = Path.Join(s_userDevCertificateLocation, $"{lookup}.key");
 
+        // We only cache PEM certificates on MacOS to avoid repeated keychain prompts.
+        // There's no concern of binary differences for PEM certs with persistent containers.
         if (OperatingSystem.IsMacOS() && certificate.IsAspNetCoreDevelopmentCertificate())
         {
-            // On macOS, we cache development certificate key material to avoid triggering repeated
-            // keychain prompts when referencing the development certificate key. We don't do this
-            // for other OSes or other certificates.
             try
             {
                 if (File.Exists(keyFileName))
@@ -316,7 +315,7 @@ private static IEnumerable<X509Certificate2> FindDevCertificates(X509Store store
                 // On macOS, cache the development certificate key material
                 try
                 {
-                    Directory.CreateDirectory(s_macOSUserDevCertificateLocation, UnixFileMode.UserExecute | UnixFileMode.UserWrite | UnixFileMode.UserRead);
+                    Directory.CreateDirectory(s_userDevCertificateLocation, UnixFileMode.UserExecute | UnixFileMode.UserWrite | UnixFileMode.UserRead);
 
                     await File.WriteAllTextAsync(keyFileName, new string(pemKey), cancellationToken).ConfigureAwait(false);
                 }
@@ -336,12 +335,12 @@ private static IEnumerable<X509Certificate2> FindDevCertificates(X509Store store
         string lookup)
     {
         byte[]? pfxBytes = null;
-        var pfxFileName = Path.Join(s_macOSUserDevCertificateLocation, $"{lookup}.pfx");
+        var pfxFileName = Path.Join(s_userDevCertificateLocation, $"{lookup}.pfx");
 
-        if (OperatingSystem.IsMacOS() && certificate.IsAspNetCoreDevelopmentCertificate())
+        // We cache PFX dev certs for all OSes to ensure consistent binary output for persistent containers
+        // in addition to avoiding repeated keychain prompts on MacOS.
+        if (certificate.IsAspNetCoreDevelopmentCertificate())
         {
-            // On macOS, we cache development certificate key material to avoid triggering repeated
-            // keychain prompts when referencing the development certificate key.
             try
             {
                 if (File.Exists(pfxFileName))
@@ -367,11 +366,18 @@ private static IEnumerable<X509Certificate2> FindDevCertificates(X509Store store
         {
             pfxBytes = certificate.Export(X509ContentType.Pfx, password);
 
-            if (pfxBytes is not null && OperatingSystem.IsMacOS() && certificate.IsAspNetCoreDevelopmentCertificate())
+            if (pfxBytes is not null && certificate.IsAspNetCoreDevelopmentCertificate())
             {
                 try
                 {
-                    Directory.CreateDirectory(s_macOSUserDevCertificateLocation, UnixFileMode.UserExecute | UnixFileMode.UserWrite | UnixFileMode.UserRead);
+                    if (OperatingSystem.IsWindows())
+                    {
+                        Directory.CreateDirectory(s_userDevCertificateLocation);
+                    }
+                    else
+                    {
+                        Directory.CreateDirectory(s_userDevCertificateLocation, UnixFileMode.UserExecute | UnixFileMode.UserWrite | UnixFileMode.UserRead);
+                    }
 
                     File.WriteAllBytes(pfxFileName, pfxBytes);
                 }