From d3fd90cd273f89b337148d667ea17d04b006c413 Mon Sep 17 00:00:00 2001 From: Dusan Jakovljevic <134404137+JakovljevicDusan@users.noreply.github.com> Date: Thu, 21 May 2026 02:36:00 +0200 Subject: [PATCH 1/2] Fix condition --- .../Configuration/Result/QltyResultConditionMgmt.Codeunit.al | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Apps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al b/src/Apps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al index 9100a4882f..d5230d5c86 100644 --- a/src/Apps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al +++ b/src/Apps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al @@ -347,7 +347,7 @@ codeunit 20409 "Qlty. Result Condition Mgmt." ToTestQltyIResultConditConf."Condition Description" := CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf."Condition Description")); ToTestQltyIResultConditConf.Insert(); end else - if AlwaysUpdateExistingCondition or (OnlyOverwriteIfADefaultCondition and (ToTestQltyIResultConditConf.Condition in [QltyInspectionResult."Default Boolean Condition", QltyInspectionResult."Default Number Condition", QltyInspectionResult."Default Text Condition"])) then begin + if AlwaysUpdateExistingCondition or (OnlyOverwriteIfADefaultCondition and (ToTestQltyIResultConditConf.Condition in ['', QltyInspectionResult."Default Boolean Condition", QltyInspectionResult."Default Number Condition", QltyInspectionResult."Default Text Condition"])) then begin ToTestQltyIResultConditConf.Validate(Condition, CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf.Condition))); ToTestQltyIResultConditConf."Condition Description" := CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf."Condition Description")); ToTestQltyIResultConditConf.Priority := QltyInspectionResult."Evaluation Sequence"; From 33939ad3525d5b7057d17f6765e75dea12a06ba9 Mon Sep 17 00:00:00 2001 From: Dusan Jakovljevic <134404137+JakovljevicDusan@users.noreply.github.com> Date: Thu, 21 May 2026 09:52:03 +0200 Subject: [PATCH 2/2] Add explanation in code --- .../Result/QltyResultConditionMgmt.Codeunit.al | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Apps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al b/src/Apps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al index d5230d5c86..1ad878f0a7 100644 --- a/src/Apps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al +++ b/src/Apps/W1/Quality Management/app/src/Configuration/Result/QltyResultConditionMgmt.Codeunit.al @@ -347,7 +347,14 @@ codeunit 20409 "Qlty. Result Condition Mgmt." ToTestQltyIResultConditConf."Condition Description" := CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf."Condition Description")); ToTestQltyIResultConditConf.Insert(); end else - if AlwaysUpdateExistingCondition or (OnlyOverwriteIfADefaultCondition and (ToTestQltyIResultConditConf.Condition in ['', QltyInspectionResult."Default Boolean Condition", QltyInspectionResult."Default Number Condition", QltyInspectionResult."Default Text Condition"])) then begin + if AlwaysUpdateExistingCondition or + (OnlyOverwriteIfADefaultCondition and + (ToTestQltyIResultConditConf.Condition in + ['', // '' treated as uninitialized; safe to overwrite just like named defaults + QltyInspectionResult."Default Boolean Condition", + QltyInspectionResult."Default Number Condition", + QltyInspectionResult."Default Text Condition"])) + then begin ToTestQltyIResultConditConf.Validate(Condition, CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf.Condition))); ToTestQltyIResultConditConf."Condition Description" := CopyStr(Condition, 1, MaxStrLen(ToTestQltyIResultConditConf."Condition Description")); ToTestQltyIResultConditConf.Priority := QltyInspectionResult."Evaluation Sequence";