Frontend test floor: vitest + RTL + mockIPC on the trial-funnel surfaces (Tier 2 opener)

[matthewod11-stack]

Description

23,714 LOC of React UI ship on type-check only — zero test files, no framework. This issue pre-scopes the minimal floor so it's pickup-ready the moment the sell sprint ends. Explicitly NOT to be built during the sell sprint (the 5/29 review's REC-7 deferral holds; one human install-and-click pass beats tests this week). (Audit finding 1.2, R-21 reconfirmed.)

Current State

• package.json: no vitest/jest/@testing-library; zero *.test.tsx? under src/
• Highest-risk untested logic, ranked:
  1. src/contexts/ConversationContext.tsx (789 lines) — streaming with 30s inactivity timeout (:376-405), chunk buffering + done-handler + fire-and-forget audit (:446-494), fail-closed PII scan (:332-350)
  2. Import pipeline (~2.9K LOC bulk-mutating customer HR data): RatingsImport 606, ColumnMappingStep 571, ReviewsImport 568, useImportPipeline 446, EnpsImport 439, EmployeeImport 417
  3. Trial/purchase/onboarding: UpgradePrompt 353, ApiKeyStep 349, ApiKeyInput 292

Suggested Fix

• Add vitest + @testing-library/react + jsdom config (no app code changes)
• Floor 1: stream-handling unit tests for ConversationContext reducer/handlers (timeout, chunk buffering, done, error paths)
• Floor 2: pure-function tests for import mapping/validation (column mapping, dedupe, error rows)
• Wire npm test into CI alongside tsc

Verification

• npm test green in CI on a clean checkout
• Coverage report exists for the two floor areas (no numeric gate yet)

Automation Hints

scope: package.json, vitest.config.ts, src/contexts/, src/components/import/, src/hooks/useImportPipeline*
do-not-touch: src-tauri/, proxy/
approach: add-tests
risk: low
max-files-changed: 15
blocked-by: none
bail-if: testing requires refactoring components to be testable beyond extracting pure functions

Priority

Medium — remove the deferred label when the sell sprint ends (~2-3 days of work).

[matthewod11-stack]

When this lands: port the #110 error-categorization cases into the vitest floor — the seven assertions (3 provider billing strings → billing/non-retryable, OpenAI true-rate-limit → rate_limit/retryable, auth + generic-500 regressions, provider-neutral no_api_key copy) are currently verified only by a one-off compiled-module harness from the #110 session. categorizeError is a pure function — ideal first target alongside the import-pipeline functions already scoped here.

[matthewod11-stack]

Pulled forward (2026-06-11, maintainer decision): this is the Tier 2 opener next session. The original deferral ("until sell-sprint ends") predates today's evidence: the entire Tier-1 trial-funnel QA had to be driven via computer-use screenshots on the founder's machine — token-heavy and machine-seizing. A minimal vitest floor converts that whole verification category into headless CI.

Minimal scope for the first pass (not the full original ambition):

• vitest + React Testing Library + @tauri-apps/api/mocks (mockIPC) setup
• ~10 tests pinning the surfaces shipped in v0.2.6 / today:
  • OnboardingContext: step 2 required flips on hasLicense; refreshLicense() re-locks it after mid-onboarding activation (Onboarding step 2 forces BYOK API-key setup that the trial never uses; trial explainer note is dead code #107/A buyer's license key has no home in onboarding — and their first-session greeting is a 'Trial complete' card re-selling them the product #111)
  • WelcomeStep: license affordance renders, activation panel swaps in, onLicenseActivated fires (A buyer's license key has no home in onboarding — and their first-session greeting is a 'Trial complete' card re-selling them the product #111)
  • UpgradePrompt: hard-mode headline is "Unlock full access" (never "Trial complete"), license button is co-primary, "no need to buy again" line renders (A buyer's license key has no home in onboarding — and their first-session greeting is a 'Trial complete' card re-selling them the product #111)
  • categorizeError: port the 7 cases from the BYOK credit/quota exhaustion misroutes to generic retryable 'Service Error' with no billing guidance or Settings path #110 verification script (anthropic credit-balance / openai insufficient_quota / gemini resource-exhausted → billing non-retryable; openai "Rate limit reached" → rate_limit retryable; auth + generic-500 regressions; provider-neutral no_api_key copy)
  • ConversationContext: one-time memory notice fires on "API key not configured" (Memory summaries & review highlights hardcode provider "anthropic" — silently dead for trial users, false error for OpenAI/Gemini BYOK customers #108)
• Original streaming/import-pipeline coverage can follow later; the floor comes first.

Reference for the #110 cases: the throwaway harness compiled src/lib/error-utils.ts with tsc and asserted against the real wrapped provider error strings — recreate those as vitest cases verbatim.