ci: drop redundant Dgraph standalone from -short unit job#21
Open
mlwelles wants to merge 1 commit into
Open
Conversation
The unit-test job runs `go test -short`, which skips every test that needs a live Dgraph. Standing up a dgraph/standalone container (and setting MODUSGRAPH_TEST_ADDR) therefore adds setup the job never uses. Remove both; the integration and load suites keep their own dedicated jobs.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit-test job runs
go test -short, which skips every test that needs a live Dgraph. Standing up adgraph/standalonecontainer (and settingMODUSGRAPH_TEST_ADDR) adds setup the-shortjob never uses.This removes the Set up Dgraph step and the
MODUSGRAPH_TEST_ADDRenv from the unit-test job. Integration and load suites keep their own dedicated jobs and are unaffected.No test coverage changes —
go test -short -race -v .still runs on both linux and macos.Summary by cubic
Remove
dgraph/standalonesetup andMODUSGRAPH_TEST_ADDRfrom the-shortunit test job, sincego test -shortskips tests that require a live Dgraph. This removes unused CI setup; integration and load suites stay separate, andgo test -short -race -v .still runs on Linux and macOS.Written for commit a4997cf. Summary will update on new commits.