Faction enums

[matigramirez]

Check that Faction enums are correct

[kurtekat]

I deleted my first comment because it wasn't very helpful.

QuestFaction

I think this would be correct:

public enum QuestFaction : byte
{
    Human,
    Elf,
    Light,
    Deatheater,
    Vail,
    Fury,
    Any
}

PortalFaction

Optionally, you could do something like this for portals because the client expects to receive certain values.

public enum PortalFaction
{
    Any,
    Light,
    Fury,
    // Invasion
    StableErdeLight = 1010,
    DeepDesertLight = 1011,
    StableErdeFury = 1020,
    DeepDesertFury = 1021,
    PalaionRegnumLight = 1060,
    ValdemarRegnumFury = 1061,
    OpalusLight = 1065,
    OpalusFury = 1066
}

EP3

0.svmap

EP6

70.svmap

81.svmap

Summary

I don't see an issue with these:

public enum KillStatusFaction : byte
{
    Light,
    Fury
}

public enum NpcFaction
{
    Any,
    Light,
    Fury
}

Not sure about these:

public enum SvmapFaction
{
    Light,
    Fury,
    Any
}

public enum WldFaction
{
    Light,
    Fury,
    Any
}

Since I don't know what led you to believe there is a bug, I'm not sure what you're looking for.

Anyhow, thanks for the library.

[matigramirez]

@kurtekat the reason why I created the issue is because some of the enums have Any as their first value (0) and others have it as their last value (2) and I wanted to make sure I'd got them right. I haven't checked them in detail yet that's why I haven't closed this. Hopefully, I'll be able to check them soon. Thank you for your input.

[kurtekat]

You're welcome.

When you do get around to it, I'm happy to help in any way.