From 358756562d61cc855c69169035434ef271cd96f0 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 5 Sep 2026 00:36:55 +0000 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Bolt:=20Replace=20fmt.Sprintf=20wit?= =?UTF-8?q?h=20string=20concatenation=20in=20workstore=20queries?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replaced fmt.Sprintf with string concatenation in buildListQuery and durable.go claim queries to remove reflection overhead in hot paths. Co-authored-by: matdev83 <211248003+matdev83@users.noreply.github.com> --- internal/infra/terminalwork/workstore/durable.go | 2 +- internal/infra/terminalwork/workstore/query_list.go | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/internal/infra/terminalwork/workstore/durable.go b/internal/infra/terminalwork/workstore/durable.go index 46939493f..f7430e76c 100644 --- a/internal/infra/terminalwork/workstore/durable.go +++ b/internal/infra/terminalwork/workstore/durable.go @@ -490,7 +490,7 @@ func (s *DurableStore) claimDueSQLite(ctx context.Context, cmd ClaimDueCommand, where = append(where, "kind = ?") args = append(args, string(cmd.Kind)) } - query := fmt.Sprintf(`SELECT * FROM economic_terminal_work WHERE %s ORDER BY created_at_unix ASC, work_id ASC`, strings.Join(where, " AND ")) + query := "SELECT * FROM economic_terminal_work WHERE " + strings.Join(where, " AND ") + " ORDER BY created_at_unix ASC, work_id ASC" var candidates []workRow if err := tx.NewRaw(query, args...).Scan(ctx, &candidates); err != nil { return nil, err diff --git a/internal/infra/terminalwork/workstore/query_list.go b/internal/infra/terminalwork/workstore/query_list.go index 131460758..0742ed60b 100644 --- a/internal/infra/terminalwork/workstore/query_list.go +++ b/internal/infra/terminalwork/workstore/query_list.go @@ -1,7 +1,6 @@ package workstore import ( - "fmt" "strings" ) @@ -27,7 +26,7 @@ func buildListQuery(storeID string, q Query, limit, offset int) (string, []any) placeholders = append(placeholders, "?") args = append(args, string(st)) } - where = append(where, fmt.Sprintf("state IN (%s)", strings.Join(placeholders, ","))) + where = append(where, "state IN ("+strings.Join(placeholders, ",")+")") } if provider := strings.TrimSpace(q.ProviderID); provider != "" { where = append(where, "provider_id = ?") @@ -63,12 +62,7 @@ func buildListQuery(storeID string, q Query, limit, offset int) (string, []any) args = append(args, q.UpdatedBefore.UTC().UnixNano()) } - query := fmt.Sprintf(` -SELECT * FROM economic_terminal_work -WHERE %s -ORDER BY created_at_unix ASC, work_id ASC -LIMIT ? OFFSET ? -`, strings.Join(where, " AND ")) + query := "SELECT * FROM economic_terminal_work WHERE " + strings.Join(where, " AND ") + " ORDER BY created_at_unix ASC, work_id ASC LIMIT ? OFFSET ?" args = append(args, limit, offset) return query, args }