During Thursday's release verification, ./Scripts/quick-deploy.sh deployed an app bundle whose Kanata Engine.app/Contents/MacOS/ was empty — the kanata submodule pin had moved (#885) and build/kanata-universal was stale/absent. The script printed its warning (⚠️ Kanata Engine.app has no kanata binary. Run ./Scripts/build-kanata.sh first.) but completed "successfully," producing an installed app where every config apply fails with Kanata binary missing.
Suggested fix: make the missing-engine case a hard failure (exit non-zero) — or better, auto-run Scripts/build-kanata.sh when build/kanata-universal is missing or the submodule pin changed since the cached build.
Cost when it bites: every CLI/config operation on the installed app fails until someone correlates the buried warning with the symptom.
During Thursday's release verification,
./Scripts/quick-deploy.shdeployed an app bundle whoseKanata Engine.app/Contents/MacOS/was empty — the kanata submodule pin had moved (#885) andbuild/kanata-universalwas stale/absent. The script printed its warning (⚠️ Kanata Engine.app has no kanata binary. Run ./Scripts/build-kanata.sh first.) but completed "successfully," producing an installed app where every config apply fails withKanata binary missing.Suggested fix: make the missing-engine case a hard failure (exit non-zero) — or better, auto-run
Scripts/build-kanata.shwhenbuild/kanata-universalis missing or the submodule pin changed since the cached build.Cost when it bites: every CLI/config operation on the installed app fails until someone correlates the buried warning with the symptom.