DM-55171: Add consolidateDiaSourceVisit to ApPipe#276
Open
Gerenjie wants to merge 1 commit into
Open
Conversation
Gerenjie
changed the title
Gerenjie
force-pushed
the
tickets/DM-55171
branch
3 times, most recently
from
367fda6 to
8851aaa
Compare
isullivan
approved these changes
Jun 8, 2026
isullivan
left a comment
isullivan
left a comment
Contributor
There was a problem hiding this comment.
See the comment on re-ordering the new task in ApPipe.yaml, and adding a new contract for the connections.
Also note that consolidateDiaSourceTable needs to be removed from Conversions.yaml and ConversionsForFakes.yaml from ap_verify
| connections.calexp: preliminary_visit_image | ||
| connections.visitSummary: preliminary_visit_summary | ||
| connections.visitSummarySchema: preliminary_visit_summary_schema | ||
| consolidateDiaSourceTable: |
Contributor
There was a problem hiding this comment.
This task has the output of standardizeDiaSource as its input, so it needs to be moved after that task in the definitions. Also, add a contract to check that the connections.inputCatalogs input connection matches the connections.diaSourceTable output of standardizeDiaSource
Gerenjie
force-pushed
the
tickets/DM-55171
branch
from
8851aaa to
6e98b8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.