Skip to content

fix: serialize split_class in split multipart requests#86

Open
pandego wants to merge 1 commit into
landing-ai:mainfrom
pandego:fix/76-split-class-json
Open

fix: serialize split_class in split multipart requests#86
pandego wants to merge 1 commit into
landing-ai:mainfrom
pandego:fix/76-split-class-json

Conversation

@pandego

@pandego pandego commented Apr 15, 2026

Copy link
Copy Markdown

Closes #76

Summary

  • serialize split_class as a JSON string before sending multipart split requests
  • accept either the documented JSON string form or the typed iterable form at the client boundary
  • add a focused multipart regression test for the split payload shape

Testing

  • uv run --with pytest --with pytest-xdist --with pytest-asyncio --with respx pytest tests/test_client.py -k 'multipart_repeating_array or split_sends_split_class_as_json_string_in_multipart'
  • uv run --with ruff ruff check src/landingai_ade/_client.py src/landingai_ade/types/client_split_params.py tests/test_client.py

@pandego pandego force-pushed the fix/76-split-class-json branch from 2952036 to 06c6be8 Compare June 6, 2026 12:48
@pandego

pandego commented Jun 6, 2026

Copy link
Copy Markdown
Author

Rebased this onto current main and resolved the generated client conflict around split_class serialization.

Validation:

  • uv run --with-requirements requirements-dev.lock pytest tests/test_client.py -k 'split_sends_split_class_as_json_string_in_multipart' -q
  • uv run --with-requirements requirements-dev.lock ruff check src/landingai_ade/_client.py src/landingai_ade/types/client_split_params.py tests/test_client.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

client.split() fails in v1.6.0

1 participant